Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2460153002: Removed xCallbackParameters from CRWSessionController class. (Closed)

Created:
4 years, 1 month ago by pkl (ping after 24h if needed)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed xCallbackParameters from CRWSessionController class. This removes xCallbackParameters from Session Controller. Committed: https://crrev.com/a80888f7a079cc7401badb282cea1fe2680a4785 Cr-Commit-Position: refs/heads/master@{#430767}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M ios/web/navigation/crw_session_controller.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 8 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pkl (ping after 24h if needed)
4 years, 1 month ago (2016-10-31 18:32:46 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years, 1 month ago (2016-10-31 19:33:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460153002/60001
4 years, 1 month ago (2016-11-08 22:39:12 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-08 23:46:11 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:49:00 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a80888f7a079cc7401badb282cea1fe2680a4785
Cr-Commit-Position: refs/heads/master@{#430767}

Powered by Google App Engine
This is Rietveld 408576698