Issue 246013002: SPDY: Headers & Push-Promise now use Continuations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246013002: SPDY: Headers & Push-Promise now use Continuations (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modify SerializeHeaders, SerializePushPromise and SpdyFrameBuilder so that HEADERS and PUSH_PROMISE frame payloads can be serialized into CONTINUATION frames as needed. This lands server change 64331353 by mlavan. BUG=345769

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase only #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+361 lines, -140 lines)			Patch
M	net/quic/spdy_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_frame_builder.h	View		3 chunks	+19 lines, -9 lines	0 comments	Download
M	net/spdy/spdy_frame_builder.cc	View		6 chunks	+37 lines, -25 lines	0 comments	Download
M	net/spdy/spdy_frame_builder_test.cc	View		4 chunks	+17 lines, -17 lines	0 comments	Download
M	net/spdy/spdy_framer.h	View	1	4 chunks	+15 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1	22 chunks	+142 lines, -66 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1	11 chunks	+83 lines, -21 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_protocol.cc	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	net/tools/quic/spdy_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/246013002/diff/1/net/spdy/spdy_frame_builder.h File net/spdy/spdy_frame_builder.h (right): https://codereview.chromium.org/246013002/diff/1/net/spdy/spdy_frame_builder.h#newcode86 net/spdy/spdy_frame_builder.h:86: } FWIW, this is a pretty complex method ...

6 years, 8 months ago (2014-04-22 03:31:52 UTC) #2

Johnny

6 years, 8 months ago (2014-04-22 15:30:51 UTC) #3

https://codereview.chromium.org/246013002/diff/1/net/spdy/spdy_frame_builder.h
File net/spdy/spdy_frame_builder.h (right):

https://codereview.chromium.org/246013002/diff/1/net/spdy/spdy_frame_builder....
net/spdy/spdy_frame_builder.h:86: }
Agreed, and noted.

On 2014/04/22 03:31:53, Ryan Hamilton wrote:
> FWIW, this is a pretty complex method for a .h file. Consider landing an
> internal change which moves this (and other non-trivial methods) to the .cc
> file.

Expand Messages | Collapse Messages