Issue 246012: Fix a bug where we get an extra resize event for background tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246012: Fix a bug where we get an extra resize event for background tabs. (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a bug where we get an extra resize event for background tabs. The TabContentsContainerGtk is a GtkFixed that contains a TabContentsViewGtk for each tab. We hide the background TCVG and only show the foreground TCVG. However, when the TCCG gets a resize event, we were still sending a set_size_request to all the background tabs. Since they were hidden, nothing happened except in the case described in issue 14114. It seems like this is a spurious resize by gtk, but not sending the resize request seems to work around it. BUG=14114 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27297

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/gtk/tab_contents_container_gtk.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm, but how does it get the correct size when it finally does show?

11 years, 3 months ago (2009-09-25 23:34:39 UTC) #2

tony

11 years, 3 months ago (2009-09-25 23:41:51 UTC) #3

On 2009/09/25 23:34:39, Evan Stade wrote:
> lgtm, but how does it get the correct size when it finally does show?

I imagine gtk always does a size allocate when you show a widget.  Wouldn't it
have to?

Expand Messages | Collapse Messages