Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 245993005: views: move native event reposting back to MenuController as it's the only (Closed)

Created:
6 years, 8 months ago by Dan Beam
Modified:
6 years, 8 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views: move native event reposting back to MenuController as it's the only caller now. R=sky@chromium.org BUG=259529 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265765

Patch Set 1 : asdf #

Patch Set 2 : asdf #

Patch Set 3 : chat with iyengar@ #

Patch Set 4 : win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -203 lines) Patch
M ui/views/controls/menu/menu_controller.cc View 1 2 3 5 chunks +89 lines, -38 lines 0 comments Download
D ui/views/event_utils.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/views/event_utils_aura.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/views/event_utils_win.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M ui/views/views.gyp View 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dan Beam
6 years, 8 months ago (2014-04-22 00:43:26 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-22 15:32:32 UTC) #2
Dan Beam
ananta@: can you give this a glance as well?
6 years, 8 months ago (2014-04-23 19:06:34 UTC) #3
ananta
lgtm
6 years, 8 months ago (2014-04-23 19:09:48 UTC) #4
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-23 19:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/245993005/90001
6 years, 8 months ago (2014-04-23 19:28:53 UTC) #6
Dan Beam
The CQ bit was unchecked by dbeam@chromium.org
6 years, 8 months ago (2014-04-23 19:35:24 UTC) #7
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-23 19:39:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/245993005/110001
6 years, 8 months ago (2014-04-23 19:40:00 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:12:39 UTC) #10
Message was sent while issue was closed.
Change committed as 265765

Powered by Google App Engine
This is Rietveld 408576698