Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2444)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 245993002: Omnibox: Create Field Trial to Always Display Hint Text (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and add mac implementation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 8198b32b7d50117cb155001cdac0ae06d748c32f..274290c72a953895745219f8fb9b9a4d075cd3e6 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/autocomplete/autocomplete_match.h"
#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
#include "chrome/browser/command_updater.h"
+#include "chrome/browser/omnibox/omnibox_field_trial.h"
#include "chrome/browser/search/search.h"
#include "chrome/browser/ui/omnibox/omnibox_edit_controller.h"
#include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
@@ -256,7 +257,8 @@ void OmniboxViewViews::Update() {
}
void OmniboxViewViews::UpdatePlaceholderText() {
- if (chrome::ShouldDisplayOriginChip())
+ if (chrome::ShouldDisplayOriginChip() ||
+ OmniboxFieldTrial::DisplayHintTextWhenPossible())
set_placeholder_text(GetHintText());
}

Powered by Google App Engine
This is Rietveld 408576698