Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2459923002: [Offline pages] Adding metrics for OIB's Open online button (Closed)
Patch Set: Addressing feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 20188277cf1f33b36f16434b5d7f8a9c89a3007a..3ba7ec01f6eeefc2ca9cf72fcd0529ad9d5ea6e1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -39910,6 +39910,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram
+ name="OfflinePages.WebsiteSettings.ConnectedWhenOpenOnlineButtonClicked"
+ enum="BooleanConnected">
+ <owner>fgorski@chromium.org</owner>
+ <summary>
+ Indicates whether the browser was online when Open online button was clicked
Alexei Svitkine (slow) 2016/11/07 23:40:00 I'm ok if you want to use the Connected terminolog
fgorski 2016/11/07 23:47:01 Done.
+ on Website Settings popup, which causes a reload of an offline page to
+ online version.
+ </summary>
+</histogram>
+
+<histogram name="OfflinePages.WebsiteSettings.OpenOnlineButtonVisible"
+ enum="BooleanVisible">
+ <owner>fgorski@chromium.org</owner>
+ <summary>
+ Indicates whether Open online was shown in Website Settings popup, when it
Alexei Svitkine (slow) 2016/11/07 23:40:00 Ditto: "was visible"?
fgorski 2016/11/07 23:47:01 Done.
+ was shown for an offline page. (The button is shown only when Chrome is
+ connected.)
+ </summary>
+</histogram>
+
<histogram name="OfflinePolicy.SuccessfulResourceLoadPercentage" units="%">
<obsolete>
Deprecated 04/2016 as doesn't have data nor owner.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698