Chromium Code Reviews Chromium Code Reviews
Issue 2459923002:
[Offline pages] Adding metrics for OIB's Open online button (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 20188277cf1f33b36f16434b5d7f8a9c89a3007a..c5791b7b5b82647469891f89d75f6027b1e2aada 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -39716,6 +39716,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Number of offline pages the user has. Android only.</summary> |
| </histogram> |
| +<histogram name="OfflinePages.OIB.OnlineWhenOpenOnlineButtonClicked" |
|
Alexei Svitkine (slow)
2016/11/07 18:34:51
Nit: I'm not sure most Chrome devs would know what
fgorski
2016/11/07 23:34:25
Done.
|
| + enum="Boolean"> |
|
Alexei Svitkine (slow)
2016/11/07 18:34:51
Please use a more specific Boolean - add it. Same
fgorski
2016/11/07 23:34:25
Ok. I am trying to reuse more specific existing en
|
| + <owner>fgorski@chromium.org</owner> |
| + <summary> |
| + Indicates whether the browser was online when Open online was clicked, which |
| + causes a reload of an offline page to online version. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="OfflinePages.OIB.OpenOnlineButtonShown" enum="Boolean"> |
| + <owner>fgorski@chromium.org</owner> |
| + <summary> |
| + Indicates whether Open online was shown in OIB, when it was shown for an |
| + offline page. (The button is shown when Chrome is connected.) |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="OfflinePages.OnlineOnOpen" enum="Boolean"> |
| <obsolete> |
| Deprecated 5/2016. Offline pages no longer depend on bookmarks UI. |
