Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/tracing/tracing-category-observer.cc

Issue 2459903003: [Tracing] Use TracingCategoryObserver in gc statistics (Closed)
Patch Set: update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/flag-definitions.h ('K') | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/tracing/tracing-category-observer.cc
diff --git a/src/tracing/tracing-category-observer.cc b/src/tracing/tracing-category-observer.cc
index f9315b4ce456beb5d55b0b02c6ca06d00e6b006e..818cad1438d93cf61b5a34acc34663385a12ac00 100644
--- a/src/tracing/tracing-category-observer.cc
+++ b/src/tracing/tracing-category-observer.cc
@@ -17,7 +17,9 @@ std::unique_ptr<TracingCategoryObserver> TracingCategoryObserver::Create() {
new TracingCategoryObserverImpl());
}
-TracingCategoryObserverImpl::TracingCategoryObserverImpl() {}
+TracingCategoryObserverImpl::TracingCategoryObserverImpl() {
+ TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.gc_stats"));
+}
TracingCategoryObserverImpl::~TracingCategoryObserverImpl() {
OnTraceDisabled();
@@ -30,10 +32,16 @@ void TracingCategoryObserverImpl::OnTraceEnabled() {
if (enabled) {
v8::internal::FLAG_runtime_stats |= ENABLED_BY_TRACING;
}
+ TRACE_EVENT_CATEGORY_GROUP_ENABLED(TRACE_DISABLED_BY_DEFAULT("v8.gc_stats"),
+ &enabled);
+ if (enabled) {
+ v8::internal::FLAG_gc_stats |= ENABLED_BY_TRACING;
+ }
}
void TracingCategoryObserverImpl::OnTraceDisabled() {
v8::internal::FLAG_runtime_stats &= ~ENABLED_BY_TRACING;
+ v8::internal::FLAG_gc_stats &= ~ENABLED_BY_TRACING;
}
} // namespace tracing
« src/flag-definitions.h ('K') | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698