[Tracing] Use TracingCategoryObserver in gc statistics

[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
Committed: https://crrev.com/7d28301d0c96a179aa9a3c96f616f7ae4b78e7e5
Cr-Commit-Position: refs/heads/master@{#40817}

[lpy, 2016-10-28 22:42:39]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 22:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-28 22:50:18]

lpy@chromium.org changed reviewers:
+ fmeawad@chromium.org

[lpy, 2016-10-28 22:50:19]

PTAL.

[commit-bot: I haz the power, 2016-10-28 23:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:12:10]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-10-31 23:03:17]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

BUG=v8:5590
==========

[lpy, 2016-10-31 23:07:33]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:07:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:39:39]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-01 00:41:36]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-11-01 00:42:01]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-01 01:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:13:08]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-01 22:10:04]

lpy@chromium.org changed reviewers:
+ mlippautz@chromium.org

[lpy, 2016-11-01 22:10:05]

+ mlippautz@ for review.

[fmeawad, 2016-11-01 22:14:41]

lgtm

Can you add more details in the description, like that you are introducing a new
flag gc_stats, and how the change should affect on and off overhead?

[Michael Lippautz, 2016-11-02 09:25:08]

https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h#...
src/flag-definitions.h:750: DEFINE_INT(gc_stats, 0, "Used by tracing internally
to enable gc statistics")
Why int and not bool?

[lpy, 2016-11-03 04:46:25]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

BUG=v8:5590
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

[lpy, 2016-11-03 04:48:22]

https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h#...
src/flag-definitions.h:750: DEFINE_INT(gc_stats, 0, "Used by tracing internally
to enable gc statistics")
On 2016/11/02 09:25:08, Michael Lippautz wrote:
> Why int and not bool? 

We still want the flag be recognizable whether it's enabled by tracing, or
command line. So if we pass track_gc_object_stats or trace_gc_object_stats flag,
then it will set it to 0x01, tracing will set it to 0x10 when we start tracing
and reset it when we stop tracing.

I made an update in description.

[Michael Lippautz, 2016-11-03 09:02:16]

On 2016/11/03 04:48:22, lpy wrote:
> https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h
> File src/flag-definitions.h (right):
> 
>
https://codereview.chromium.org/2459903003/diff/40001/src/flag-definitions.h#...
> src/flag-definitions.h:750: DEFINE_INT(gc_stats, 0, "Used by tracing
internally
> to enable gc statistics")
> On 2016/11/02 09:25:08, Michael Lippautz wrote:
> > Why int and not bool? 
> 
> We still want the flag be recognizable whether it's enabled by tracing, or
> command line. So if we pass track_gc_object_stats or trace_gc_object_stats
flag,
> then it will set it to 0x01, tracing will set it to 0x10 when we start tracing
> and reset it when we stop tracing.
> 
> I made an update in description.

Thanks for the explanation, lgtm

[lpy, 2016-11-03 18:24:40]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 18:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:51:56]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-03 22:02:09]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 22:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:29:50]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-04 17:07:16]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:35:43]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-04 17:36:11]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-11-04 17:36:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2459903003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-04 17:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:38:25]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

[commit-bot: I haz the power, 2016-11-04 17:38:26]

Committed patchset #5 (id:100001)

[Michael Achenbach, 2016-11-05 13:27:09]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/2477143002/ by machenbach@chromium.org.

The reason for reverting is: Speculative revert for blocking roll:
https://codereview.chromium.org/2473003006/

E.g.:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

[Michael Achenbach, 2016-11-05 13:29:19]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

[Michael Achenbach, 2016-11-05 13:29:47]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-11-05 13:29:48]

Reopened this CL to test reland with chromium trybot.

[lpy, 2016-11-07 06:12:43]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 06:12:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 06:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 06:40:15]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-11-07 20:51:59]

Patchset #6 (id:120001) has been deleted

[lpy, 2016-11-07 21:09:10]

Patchset #6 (id:140001) has been deleted

[lpy, 2016-11-08 02:12:47]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-11-08 02:12:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2459903003/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-08 02:12:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:13:49]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

[commit-bot: I haz the power, 2016-11-08 03:13:51]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-11-17 22:23:27]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590

Committed: https://crrev.com/75f1473880b875109bbea3f5202316347d46b549
Cr-Commit-Position: refs/heads/master@{#40777}
==========

[commit-bot: I haz the power, 2016-11-17 22:23:29]

Patchset 6 (id:??) landed as
https://crrev.com/75f1473880b875109bbea3f5202316347d46b549
Cr-Commit-Position: refs/heads/master@{#40777}

[commit-bot: I haz the power, 2016-11-17 22:25:23]

Description was changed from

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590

Committed: https://crrev.com/75f1473880b875109bbea3f5202316347d46b549
Cr-Commit-Position: refs/heads/master@{#40777}
==========

to

==========
[Tracing] Use TracingCategoryObserver in gc statistics

This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590

Committed: https://crrev.com/7d28301d0c96a179aa9a3c96f616f7ae4b78e7e5
Cr-Commit-Position: refs/heads/master@{#40817}
==========

[commit-bot: I haz the power, 2016-11-17 22:25:24]

Patchset 6 (id:??) landed as
https://crrev.com/7d28301d0c96a179aa9a3c96f616f7ae4b78e7e5
Cr-Commit-Position: refs/heads/master@{#40817}