Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2459883002: Log SSL.MarkHttpAs histogram without regard to state of the page (Closed)

Created:
4 years, 1 month ago by elawrence
Modified:
4 years, 1 month ago
Reviewers:
*estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log SSL.MarkHttpAs histogram without regard to state of the page The SSL.MarkHTTPAs histogram should record the state of the switch or field trial group regardless of whether or not the current page has a non-secure password field. BUG=660226 Committed: https://crrev.com/c4c0ef66fbec87aef17d8d24036a9465251d3ae8 Cr-Commit-Position: refs/heads/master@{#428382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M components/security_state/security_state_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/security_state/security_state_model_unittest.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
elawrence
PTAL?
4 years, 1 month ago (2016-10-28 14:43:48 UTC) #5
estark
lgtm, thanks!
4 years, 1 month ago (2016-10-28 15:10:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459883002/1
4 years, 1 month ago (2016-10-28 15:34:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 15:40:15 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 15:49:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4c0ef66fbec87aef17d8d24036a9465251d3ae8
Cr-Commit-Position: refs/heads/master@{#428382}

Powered by Google App Engine
This is Rietveld 408576698