Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2459823002: [Sync] Rename syncable_prefs to sync_preferences. (Closed)

Created:
4 years, 1 month ago by maxbogue
Modified:
4 years, 1 month ago
Reviewers:
jam, battre
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, jam, sadrul, yusukes+watch_chromium.org, droger+watchlist_chromium.org, tzik, michaelpg+watch-md-settings_chromium.org, shuchen+watch_chromium.org, hidehiko+watch_chromium.org, oka+watch_chromium.org, browser-components-watch_chromium.org, rginda+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, fukino+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, awdf+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, sebsg+autofillwatch_chromium.org, sdefresne+watchlist_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, khmel+watch_chromium.org, nona+watch_chromium.org, je_julie, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, mlamouri+watch-notifications_chromium.org, alemate+watch_chromium.org, blundell+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, derat+watch_chromium.org, rouslan+autofill_chromium.org, yamaguchi+watch_chromium.org, yuzo+watch_chromium.org, pam+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, Matt Giuca, elijahtaylor+arcwatch_chromium.org, Peter Beverloo, mathp+autofillwatch_chromium.org, tfarina, nektar+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pfeldman, dtseng+watch_chromium.org, mac-reviews_chromium.org, estade+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename syncable_prefs to sync_preferences. Pretty mechanical CL: - Moved files and ran mass-rename.py - String-replaced "syncable_prefs" with "sync_preferences" - String-replaced "SYNCABLE_PREFS_USE_POLICY" with "SYNC_PREFERENCES_USE_POLICY" - Fixed a couple lints inside sync_preferences - Ran formatter BUG=659265 TBR=jam Committed: https://crrev.com/ea16ff4188c0dddbdbd42d08793b55ad77b81fa4 Cr-Commit-Position: refs/heads/master@{#428391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+694 lines, -3426 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_mapping_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/content_autofill_driver_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/managed_bookmark_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization/customization_document_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 26 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_rsa.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_loader.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_prefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/font_family_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_command_line_pref_store_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_command_line_pref_store_ssl_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_model_associator_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_metrics_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_metrics_service.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_util.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_util.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_destroyer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/cross_device_promo_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/cross_device_promo_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/speech_auth_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/base/testing_profile_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M components/browser_sync/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_startup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/sync/browser/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/sync/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/sync/browser/password_manager_setting_migrator_service.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/password_manager/sync/browser/password_manager_setting_migrator_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/driver/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_sync_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/driver/startup_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync_preferences/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
A + components/sync_preferences/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync_preferences/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/sync_preferences/pref_model_associator.h View 6 chunks +10 lines, -11 lines 0 comments Download
A + components/sync_preferences/pref_model_associator.cc View 14 chunks +26 lines, -37 lines 0 comments Download
A + components/sync_preferences/pref_model_associator_client.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_preferences/pref_model_associator_unittest.cc View 7 chunks +13 lines, -17 lines 0 comments Download
A + components/sync_preferences/pref_service_mock_factory.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/sync_preferences/pref_service_mock_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable.h View 2 chunks +8 lines, -7 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable.cc View 5 chunks +9 lines, -12 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable_factory.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable_factory.cc View 3 chunks +10 lines, -12 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_preferences/pref_service_syncable_unittest.cc View 15 chunks +39 lines, -50 lines 0 comments Download
A + components/sync_preferences/synced_pref_change_registrar.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + components/sync_preferences/synced_pref_change_registrar.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + components/sync_preferences/synced_pref_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/sync_preferences/testing_pref_service_syncable.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + components/sync_preferences/testing_pref_service_syncable.cc View 4 chunks +16 lines, -19 lines 0 comments Download
D components/syncable_prefs/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D components/syncable_prefs/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D components/syncable_prefs/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/syncable_prefs/pref_model_associator.h View 1 chunk +0 lines, -209 lines 0 comments Download
D components/syncable_prefs/pref_model_associator.cc View 1 chunk +0 lines, -545 lines 0 comments Download
D components/syncable_prefs/pref_model_associator_client.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/syncable_prefs/pref_model_associator_unittest.cc View 1 chunk +0 lines, -445 lines 0 comments Download
D components/syncable_prefs/pref_service_mock_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/syncable_prefs/pref_service_mock_factory.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable.h View 1 chunk +0 lines, -121 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable_factory.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable_factory.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/syncable_prefs/pref_service_syncable_unittest.cc View 1 chunk +0 lines, -574 lines 0 comments Download
D components/syncable_prefs/synced_pref_change_registrar.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/syncable_prefs/synced_pref_change_registrar.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D components/syncable_prefs/synced_pref_observer.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/syncable_prefs/testing_pref_service_syncable.h View 1 chunk +0 lines, -56 lines 0 comments Download
D components/syncable_prefs/testing_pref_service_syncable.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.h View 6 chunks +7 lines, -7 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/prefs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_model_associator_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/authentication_service_unittest.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/sync/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
maxbogue
battre@, PTAL! See the bug for more context.
4 years, 1 month ago (2016-10-28 04:20:16 UTC) #7
battre
lgtm
4 years, 1 month ago (2016-10-28 07:00:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459823002/1
4 years, 1 month ago (2016-10-28 07:00:54 UTC) #10
battre
Sorry, the CQ was probably too early lacking some top level OWNERS approval.
4 years, 1 month ago (2016-10-28 07:02:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/291818)
4 years, 1 month ago (2016-10-28 07:11:28 UTC) #13
maxbogue
TBR jam@ for everything.
4 years, 1 month ago (2016-10-28 16:21:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459823002/1
4 years, 1 month ago (2016-10-28 16:22:05 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 16:36:01 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 16:51:12 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea16ff4188c0dddbdbd42d08793b55ad77b81fa4
Cr-Commit-Position: refs/heads/master@{#428391}

Powered by Google App Engine
This is Rietveld 408576698