Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2459753002: Revert of Roll ANGLE af7f301..1d2c41d (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE af7f301..1d2c41d (patchset #1 id:1 of https://codereview.chromium.org/2457883002/ ) Reason for revert: breaks build https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/11909/steps/compile/logs/stdio Original issue's description: > Roll ANGLE af7f301..1d2c41d > > https://chromium.googlesource.com/angle/angle.git/+log/af7f301..1d2c41d > > BUG=658555, chromium:659326, 540829, 655247 > > TBR=jmadill@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/a16bd358e88a73acb35843f44719783f24087234 > Cr-Commit-Position: refs/heads/master@{#428138} TBR=jmadill@chromium.org,geofflang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658555, chromium:659326, 540829, 655247 Committed: https://crrev.com/9bfaa6948251aae2a4f2b8ca178e8c9c3f5e78c3 Cr-Commit-Position: refs/heads/master@{#428148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
Created Revert of Roll ANGLE af7f301..1d2c41d
4 years, 1 month ago (2016-10-27 21:46:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459753002/1
4 years, 1 month ago (2016-10-27 21:47:24 UTC) #3
Jamie Madill
argh, revenge of the ASSERT unreferenced bug. lgtm, sorry about that.
4 years, 1 month ago (2016-10-27 21:47:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 21:50:09 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:52:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bfaa6948251aae2a4f2b8ca178e8c9c3f5e78c3
Cr-Commit-Position: refs/heads/master@{#428148}

Powered by Google App Engine
This is Rietveld 408576698