Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2459693002: swarming: display named caches in task UI (Closed)

Created:
4 years, 1 month ago by nodir
Modified:
4 years, 1 month ago
Reviewers:
KevinL, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: display named caches in task UI Update both old and new UI R=kjlubick@chromium.org, maruel@chromium.org BUG=654562 Committed: https://github.com/luci/luci-py/commit/feb2aa3fd5b344c44ba67fdc1cd58906bb8d1ec7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M appengine/swarming/templates/user_task.html View 1 chunk +14 lines, -0 lines 0 comments Download
M appengine/swarming/ui/build/elements.html View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nodir
PTAL elements.html was generated by running `make vulcanize`. I did some other stuff that i ...
4 years, 1 month ago (2016-10-27 19:25:13 UTC) #1
KevinL
lgtm I don't know why common-strings.js-e was created, but you were right to delete it ...
4 years, 1 month ago (2016-10-27 19:29:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459693002/1
4 years, 1 month ago (2016-10-27 19:44:53 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:48:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/feb2aa3fd5b344c44ba67fdc1cd58906bb8d1ec7

Powered by Google App Engine
This is Rietveld 408576698