Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2459673002: Fix some FX_BOOL / int noise in core/fx* (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix some FX_BOOL / int noise in core/fx* #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M core/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 6 chunks +15 lines, -19 lines 1 comment Download
M core/fxge/ge/cfx_renderdevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/2459673002/diff/20001/core/fxge/agg/fx_agg_driver.cpp File core/fxge/agg/fx_agg_driver.cpp (right): https://codereview.chromium.org/2459673002/diff/20001/core/fxge/agg/fx_agg_driver.cpp#newcode1751 core/fxge/agg/fx_agg_driver.cpp:1751: SetDeviceDriver(pdfium::MakeUnique<CFX_AggDeviceDriver>(pBitmap, false, Note: Because FALSE gets ...
4 years, 1 month ago (2016-10-27 17:59:29 UTC) #2
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-27 18:50:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459673002/20001
4 years, 1 month ago (2016-10-27 19:57:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:57:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/5c15e67e12e245d102a2e0ef1b4ade54379f...

Powered by Google App Engine
This is Rietveld 408576698