Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/execution.cc

Issue 245963007: Clean up some uses of Failures and MaybeObjects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | src/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "execution.h" 5 #include "execution.h"
6 6
7 #include "bootstrapper.h" 7 #include "bootstrapper.h"
8 #include "codegen.h" 8 #include "codegen.h"
9 #include "deoptimizer.h" 9 #include "deoptimizer.h"
10 #include "isolate-inl.h" 10 #include "isolate-inl.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 // Reset stepping state when script exits with uncaught exception. 107 // Reset stepping state when script exits with uncaught exception.
108 if (isolate->debugger()->IsDebuggerActive()) { 108 if (isolate->debugger()->IsDebuggerActive()) {
109 isolate->debug()->ClearStepping(); 109 isolate->debug()->ClearStepping();
110 } 110 }
111 #endif // ENABLE_DEBUGGER_SUPPORT 111 #endif // ENABLE_DEBUGGER_SUPPORT
112 return MaybeHandle<Object>(); 112 return MaybeHandle<Object>();
113 } else { 113 } else {
114 isolate->clear_pending_message(); 114 isolate->clear_pending_message();
115 } 115 }
116 116
117 return Handle<Object>(value->ToObjectUnchecked(), isolate); 117 return Handle<Object>(value, isolate);
118 } 118 }
119 119
120 120
121 MaybeHandle<Object> Execution::Call(Isolate* isolate, 121 MaybeHandle<Object> Execution::Call(Isolate* isolate,
122 Handle<Object> callable, 122 Handle<Object> callable,
123 Handle<Object> receiver, 123 Handle<Object> receiver,
124 int argc, 124 int argc,
125 Handle<Object> argv[], 125 Handle<Object> argv[],
126 bool convert_receiver) { 126 bool convert_receiver) {
127 if (!callable->IsJSFunction()) { 127 if (!callable->IsJSFunction()) {
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 if (stack_guard->IsInstallCodeRequest()) { 985 if (stack_guard->IsInstallCodeRequest()) {
986 ASSERT(isolate->concurrent_recompilation_enabled()); 986 ASSERT(isolate->concurrent_recompilation_enabled());
987 stack_guard->Continue(INSTALL_CODE); 987 stack_guard->Continue(INSTALL_CODE);
988 isolate->optimizing_compiler_thread()->InstallOptimizedFunctions(); 988 isolate->optimizing_compiler_thread()->InstallOptimizedFunctions();
989 } 989 }
990 isolate->runtime_profiler()->OptimizeNow(); 990 isolate->runtime_profiler()->OptimizeNow();
991 return isolate->heap()->undefined_value(); 991 return isolate->heap()->undefined_value();
992 } 992 }
993 993
994 } } // namespace v8::internal 994 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698