Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: test/mjsunit/debug-scopes.js

Issue 245963006: Avoid exposing compiler-allocated temporaries to the debugger (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 } 159 }
160 count++; 160 count++;
161 } 161 }
162 162
163 // 'arguments' and might be exposed in the local and closure scope. Just 163 // 'arguments' and might be exposed in the local and closure scope. Just
164 // ignore this. 164 // ignore this.
165 var scope_size = scope.scopeObject().properties().length; 165 var scope_size = scope.scopeObject().properties().length;
166 if (!scope.scopeObject().property('arguments').isUndefined()) { 166 if (!scope.scopeObject().property('arguments').isUndefined()) {
167 scope_size--; 167 scope_size--;
168 } 168 }
169 // Also ignore synthetic variable from catch block.
170 if (!scope.scopeObject().property('.catch-var').isUndefined()) {
171 scope_size--;
172 }
173 // Skip property with empty name. 169 // Skip property with empty name.
174 if (!scope.scopeObject().property('').isUndefined()) { 170 if (!scope.scopeObject().property('').isUndefined()) {
175 scope_size--; 171 scope_size--;
176 } 172 }
177 173
178 if (count != scope_size) { 174 if (count != scope_size) {
179 print('Names found in scope:'); 175 print('Names found in scope:');
180 var names = scope.scopeObject().propertyNames(); 176 var names = scope.scopeObject().propertyNames();
181 for (var i = 0; i < names.length; i++) { 177 for (var i = 0; i < names.length; i++) {
182 print(names[i]); 178 print(names[i]);
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 CheckScopeContent({e:'Exception'}, 0, exec_state); 1009 CheckScopeContent({e:'Exception'}, 0, exec_state);
1014 }; 1010 };
1015 catch_block_7(); 1011 catch_block_7();
1016 EndTest(); 1012 EndTest();
1017 1013
1018 1014
1019 assertEquals(begin_test_count, break_count, 1015 assertEquals(begin_test_count, break_count,
1020 'one or more tests did not enter the debugger'); 1016 'one or more tests did not enter the debugger');
1021 assertEquals(begin_test_count, end_test_count, 1017 assertEquals(begin_test_count, end_test_count,
1022 'one or more tests did not have its result checked'); 1018 'one or more tests did not have its result checked');
OLDNEW
« no previous file with comments | « test/mjsunit/bugs/harmony/debug-blockscopes.js ('k') | test/mjsunit/harmony/debug-blockscopes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698