Adds SharedWorker related UMAs to histograms.xml.

Adds SharedWorker related UMAs to histograms.xml.

I add the followings to histograms.xml.
  SharedWorker.RendererSurviveForWorkerTime
  SharedWorker.TimeToDeleted
  SharedWorker.TimeToScriptLoaded
  SharedWorker.TimeToScriptLoadFailed

They were introduced in http://crrev.com/259790 and http://crrev.com/260376.

BUG=327256
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266389

[horo, 2014-04-22 02:03:05]

kinuko@
Could you please review?

[kinuko, 2014-04-22 03:26:44]

lgtm

UAM -> UMA in the issue subject

https://codereview.chromium.org/245963004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23117: +  <summary>The lifetime of a
SharedWorkerHost.</summary>
Would be nice to note that what this means (e.g. roughly corresponds to the
lifetime of SharedWorker)

[horo, 2014-04-22 03:50:00]

https://codereview.chromium.org/245963004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23117: +  <summary>The lifetime of a
SharedWorkerHost.</summary>
On 2014/04/22 03:26:44, kinuko wrote:
> Would be nice to note that what this means (e.g. roughly corresponds to the
> lifetime of SharedWorker)

Done.

[horo, 2014-04-22 03:50:23]

jar@
Could you please review?

[jar (doing other things), 2014-04-22 17:47:57]

a) Best practice is to land these changes along with the actual code, so that
you can get comments on both.

b) I suspect (not sure) that the times involved are rather short, and probably
more akin to queueing latency.  Did you really want "LONG_TIMES" to be the range
for histograms??  IF you don't need times over about 10 seconds, than
UMA_HISTOGRAM_TIMES() would have been a better choice.

c) Asvvitkine@ is often a better reviewer.

d) See comment below.

https://codereview.chromium.org/245963004/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23115: +<histogram
name="SharedWorker.TimeToDeleted" units="microseconds">
These are really milliseconds, based on the code (I think).

[horo, 2014-04-24 07:55:17]

Sorry, I didn't understand how to add UMAs.

SharedWorker.TimeToDeleted and SharedWorker.RendererSurviveForWorkerTime could
be bigger than 10 seconds.

https://codereview.chromium.org/245963004/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23115: +<histogram
name="SharedWorker.TimeToDeleted" units="microseconds">
On 2014/04/22 17:47:57, jar wrote:
> These are really milliseconds, based on the code (I think).

Done.

[horo, 2014-04-25 09:49:03]

asvitkine@
Could you please review this?
Thank you.

[Alexei Svitkine (slow), 2014-04-25 14:32:41]

lgtm

https://codereview.chromium.org/245963004/diff/30001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/30001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23137: +    of SharedWorker
Nit: Add .

[horo, 2014-04-25 15:41:20]

https://codereview.chromium.org/245963004/diff/30001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/245963004/diff/30001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23137: +    of SharedWorker
On 2014/04/25 14:32:41, Alexei Svitkine wrote:
> Nit: Add .

Done.

[horo, 2014-04-25 15:41:24]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:16:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/245963004/70001

[commit-bot: I haz the power, 2014-04-26 03:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:22:25]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[horo, 2014-04-26 05:39:45]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-04-26 05:41:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/245963004/70001

[commit-bot: I haz the power, 2014-04-26 22:34:42]

Change committed as 266389