Correctly rebaseline 2DCanvasWebGL pixel test

Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522, 660118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Committed: https://crrev.com/679b26ff61f303d85a56f5df1fd6199f209ad7ca
Cr-Commit-Position: refs/heads/master@{#428245}

[ajuma, 2016-10-27 18:27:54]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[ajuma, 2016-10-27 18:27:59]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[ajuma, 2016-10-27 18:28:30]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[ajuma, 2016-10-27 18:28:30]

ajuma@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-27 18:30:06]

Thanks to xidachen@ for pointing me to this file.

Just to make sure, waiting for a review rather than TBR-ing this time. If this
change is correct, I'll also update the pixel wrangler documentation.

[xidachen, 2016-10-27 18:35:24]

On 2016/10/27 18:30:06, ajuma wrote:
> Thanks to xidachen@ for pointing me to this file.
> 
> Just to make sure, waiting for a review rather than TBR-ing this time. If this
> change is correct, I'll also update the pixel wrangler documentation.

If I am not mistaken, you'd have to label this test as failure in the
pixel_expectation:
https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/pixel_expecta...

[ajuma, 2016-10-27 19:37:42]

On 2016/10/27 18:35:24, xidachen wrote:
> On 2016/10/27 18:30:06, ajuma wrote:
> > Thanks to xidachen@ for pointing me to this file.
> > 
> > Just to make sure, waiting for a review rather than TBR-ing this time. If
this
> > change is correct, I'll also update the pixel wrangler documentation.
> 
> If I am not mistaken, you'd have to label this test as failure in the
> pixel_expectation:
>
https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/pixel_expecta...

Thanks, done.

[xidachen, 2016-10-27 20:12:25]

xidachen@chromium.org changed reviewers:
+ xidachen@chromium.org

[xidachen, 2016-10-27 20:12:26]

https://codereview.chromium.org/2459613003/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (right):

https://codereview.chromium.org/2459613003/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:49:
self.Fail('Pixel_2DCanvasWebGL', ['android'], bug=660118)
I believe that you should remove the ['android'] because all platform will now
trying to find reference images with 'v3' in its name.

lgtm with the above change, modulo kbr@'s lgtm.

[ajuma, 2016-10-27 20:16:33]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:17:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-27 20:18:30]

https://codereview.chromium.org/2459613003/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (right):

https://codereview.chromium.org/2459613003/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:49:
self.Fail('Pixel_2DCanvasWebGL', ['android'], bug=660118)
On 2016/10/27 20:12:26, xidachen wrote:
> I believe that you should remove the ['android'] because all platform will now
> trying to find reference images with 'v3' in its name.
> 
> lgtm with the above change, modulo kbr@'s lgtm.

Done.

[Ken Russell (switch to Gerrit), 2016-10-27 22:00:59]

lgtm too. Thanks for taking care of this.

[ajuma, 2016-10-27 22:02:30]

The CQ bit was unchecked by ajuma@chromium.org

[ajuma, 2016-10-27 22:02:34]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-10-27 22:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
xidachen@chromium.org
Link to the patchset: https://codereview.chromium.org/2459613003/#ps40001
(title: "Expand expectation to all platforms")

[commit-bot: I haz the power, 2016-10-27 22:03:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-27 23:10:45]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[ajuma, 2016-10-27 23:11:15]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-10-27 23:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
xidachen@chromium.org
Link to the patchset: https://codereview.chromium.org/2459613003/#ps60001
(title: "Add ES3 version of test to expectations since it uses the same revision
#")

[commit-bot: I haz the power, 2016-10-27 23:12:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:44:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Russell (switch to Gerrit), 2016-10-28 00:52:09]

On 2016/10/28 00:44:11, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

It would be great if you'd file a bug about those unrelated failures but we
really need this fix in the tree so I'm bypassing the CQ.

[Ken Russell (switch to Gerrit), 2016-10-28 00:52:19]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
==========

[Ken Russell (switch to Gerrit), 2016-10-28 00:52:23]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:53:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:15:17]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
==========

[commit-bot: I haz the power, 2016-10-28 02:15:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-28 02:19:05]

Description was changed from

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
==========

to

==========
Correctly rebaseline 2DCanvasWebGL pixel test

This is a follow-up to http://crrev.com/2451383003, which updated
an obsolete file.

BUG=629522,660118

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Committed: https://crrev.com/679b26ff61f303d85a56f5df1fd6199f209ad7ca
Cr-Commit-Position: refs/heads/master@{#428245}
==========

[commit-bot: I haz the power, 2016-10-28 02:19:06]

Patchset 4 (id:??) landed as
https://crrev.com/679b26ff61f303d85a56f5df1fd6199f209ad7ca
Cr-Commit-Position: refs/heads/master@{#428245}

[ajuma, 2016-10-28 14:05:08]

On 2016/10/28 00:52:09, Ken Russell wrote:
> On 2016/10/28 00:44:11, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> 
> It would be great if you'd file a bug about those unrelated failures but we
> really need this fix in the tree so I'm bypassing the CQ.

Thanks for landing this. Looks like those unrelated failures have been addressed
by https://codereview.chromium.org/2450353005/