Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2459603004: Stop casting function pointers to data pointers in fx_win32_gdipext.cpp. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Stop casting function pointers to data pointers in fx_win32_gdipext.cpp. Only bad people do that, since it's prohibited by the C standards. Committed: https://pdfium.googlesource.com/pdfium/+/159ba95782e0610b217c42a60bbfbd99737e0771

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : Early return preferred #

Patch Set 4 : Typo, casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M core/fxge/win32/fx_win32_gdipext.cpp View 1 2 3 2 chunks +14 lines, -17 lines 0 comments Download
M core/fxge/win32/win32_int.h View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Tom Sepez
Lei, for review (only tested on bots, not locally. Hooray batch processing).
4 years, 1 month ago (2016-10-28 18:01:38 UTC) #8
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-28 18:03:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459603004/60001
4 years, 1 month ago (2016-10-28 18:09:36 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 18:16:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/159ba95782e0610b217c42a60bbfbd99737e...

Powered by Google App Engine
This is Rietveld 408576698