Issue 2459593002: make the parser able to parse old versions of the codec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2459593002: make the parser able to parse old versions of the codec (Closed)

Created:
4 years, 1 month ago by Harry Terkelsen

Modified:
4 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang), sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

make the parser able to parse old versions of the codec R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/eb7f91eed9f5d7e02ef8043613a225165a03bcca

Patch Set 1 #

Total comments: 1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -14 lines)			Patch
	M	lib/json_info_codec.dart	View		2 chunks	+61 lines, -13 lines	1 comment	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Harry Terkelsen

Committed patchset #1 (id:1) manually as eb7f91eed9f5d7e02ef8043613a225165a03bcca (presubmit successful).

4 years, 1 month ago (2016-10-27 14:12:05 UTC) #5

sra1

4 years, 1 month ago (2016-10-27 14:19:47 UTC) #6

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2459593002/diff/1/lib/json_info_codec.dart
File lib/json_info_codec.dart (right):

https://codereview.chromium.org/2459593002/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:168: if (toJsonDuration is String) {
You could put this repeated if-then-else in a helper

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages