Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(271)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/installer/setup/brand_constants.cc
Issue
2459583002
:
Use InstallDetails in setup. (Closed)
Patch Set:
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/installer/setup/BUILD.gn
chrome/installer/setup/DEPS
chrome/installer/setup/app_launcher_installer.cc
chrome/installer/setup/brand_constants.h
chrome/installer/setup/brand_constants.cc
chrome/installer/setup/brand_constants_unittest.cc
chrome/installer/setup/chromium_constants.cc
chrome/installer/setup/google_chrome_constants.cc
chrome/installer/setup/install.cc
chrome/installer/setup/install_unittest.cc
chrome/installer/setup/install_worker.cc
chrome/installer/setup/install_worker_unittest.cc
chrome/installer/setup/setup_install_details.h
chrome/installer/setup/setup_install_details.cc
chrome/installer/setup/setup_main.cc
chrome/installer/setup/uninstall.cc
View unified diff
|
Download patch
« chrome/installer/setup/brand_constants.h
('K') |
« chrome/installer/setup/brand_constants.h
('k') |
chrome/installer/setup/brand_constants_unittest.cc »
('j') |
chrome/installer/setup/install_worker.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#include "chrome/installer/setup/brand_constants.h"
6
7
#include "chrome/install_static/install_details.h"
8
9
const BrandConstants& GetBrandConstants() {
10
return kBrandConstants[install_static::InstallDetails::Get()
11
.install_mode_index()];
12
}
OLD
NEW
« chrome/installer/setup/brand_constants.h
('K') |
« chrome/installer/setup/brand_constants.h
('k') |
chrome/installer/setup/brand_constants_unittest.cc »
('j') |
chrome/installer/setup/install_worker.cc »
('J')
Issue 2459583002: Use InstallDetails in setup. (Closed)
Created 4 years, 1 month ago by grt (UTC plus 2)
Modified 3 years, 9 months ago
Reviewers: robertshield
Base URL:
Comments: 34
This is Rietveld
408576698