Add UnlinkedUnit.isPartOf flag.

Add UnlinkedUnit.isPartOf flag.

We need this flag for now until https://github.com/dart-lang/sdk/issues/20792
is resolved.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f0ed21effc9dd4f33bfca863c6c3e500434f4c9a

[Brian Wilkerson, 2016-10-31 13:20:53]

lgtm

[Paul Berry, 2016-10-31 20:20:50]

lgtm assuming nit is addressed.

https://codereview.chromium.org/2459573005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2459573005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:2698: * Indicates whether the unit is a
part-of a library.
Nit: let's change this doc comment to something like:

"Indicates whether the unit contains a "part of" declaration.

(Since it's possible, in invalid code, to have a mismatch between "part" and
"part of" declarations, I want to make sure it's absolutely clear that this
boolean is based solely on the contents of the file being analyzed; it does not
depend on whether some other file actually has a "part" declaration that points
to this file).

[scheglov, 2016-10-31 21:01:57]

https://codereview.chromium.org/2459573005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2459573005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:2698: * Indicates whether the unit is a
part-of a library.
On 2016/10/31 20:20:50, Paul Berry wrote:
> Nit: let's change this doc comment to something like:
> 
> "Indicates whether the unit contains a "part of" declaration.
> 
> (Since it's possible, in invalid code, to have a mismatch between "part" and
> "part of" declarations, I want to make sure it's absolutely clear that this
> boolean is based solely on the contents of the file being analyzed; it does
not
> depend on whether some other file actually has a "part" declaration that
points
> to this file).

Done.

[scheglov, 2016-10-31 21:03:14]

Description was changed from

==========
Add UnlinkedUnit.isPartOf flag.

We need this flag for now until https://github.com/dart-lang/sdk/issues/20792
is resolved.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add UnlinkedUnit.isPartOf flag.

We need this flag for now until https://github.com/dart-lang/sdk/issues/20792
is resolved.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f0ed21effc9dd4f33bfca863c6c3e500434f4c9a
==========

[scheglov, 2016-10-31 21:03:15]

Committed patchset #2 (id:20001) manually as
f0ed21effc9dd4f33bfca863c6c3e500434f4c9a (presubmit successful).