Added skslc parse recursion limit

Added skslc parse recursion limit

The fuzzer discovered that a long chain of left-parentheses would cause a stack overflow due to excessive recursion. While it is not in general possible to guarantee that we do not exceed stack limits (because the system can be configured with an arbitrarily small stack), setting a reasonable recursion limit will at least keep the fuzzer from continually finding more "bugs" like this.

BUG=skia:5899
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2459573003

Committed: https://skia.googlesource.com/skia/+/cad6416ccbf103648874b0f5fb615ec5ac798f14

[ethannicholas, 2016-10-27 14:29:21]

Description was changed from

==========
Added skslc parse recursion limit

The fuzzer discovered that a long chain of left-parentheses would cause a stack
overflow due to excessive recursion. While it is not in general possible to
guarantee that we do not exceed stack limits (because the system can be
configured with an arbitrarily small stack), setting a reasonable recursion
limit will at least keep the fuzzer from continually finding more "bugs" like
this.

BUG=skia:5899
==========

to

==========
Added skslc parse recursion limit

The fuzzer discovered that a long chain of left-parentheses would cause a stack
overflow due to excessive recursion. While it is not in general possible to
guarantee that we do not exceed stack limits (because the system can be
configured with an arbitrarily small stack), setting a reasonable recursion
limit will at least keep the fuzzer from continually finding more "bugs" like
this.

BUG=skia:5899
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2459573003
==========

[ethannicholas, 2016-10-27 14:30:55]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:31:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 14:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 14:31:52]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on
master.client.skia.android (JOB_FAILED,
http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-arm-Debug-GN_Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-a...)
  Build-Ubuntu-Clang-arm64-Debug-GN_Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-a...)
  Build-Ubuntu-Clang-arm64-Debug-GN_Android_FrameworkDefs-Trybot on
master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-a...)
  Build-Ubuntu-Clang-mips64el-Debug-GN_Android-Trybot on
master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-m...)
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[ethannicholas, 2016-10-27 14:41:08]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:41:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:01:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:01:30]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-10-27 15:02:06]

ethannicholas@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2016-10-27 15:09:23]

lgtm

Unfortunate that we're making code changes only to satisfy fuzzer, but at least
it's not too intrusive.

[ethannicholas, 2016-10-27 17:53:04]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2016-10-27 17:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 17:54:04]

Description was changed from

==========
Added skslc parse recursion limit

The fuzzer discovered that a long chain of left-parentheses would cause a stack
overflow due to excessive recursion. While it is not in general possible to
guarantee that we do not exceed stack limits (because the system can be
configured with an arbitrarily small stack), setting a reasonable recursion
limit will at least keep the fuzzer from continually finding more "bugs" like
this.

BUG=skia:5899
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2459573003
==========

to

==========
Added skslc parse recursion limit

The fuzzer discovered that a long chain of left-parentheses would cause a stack
overflow due to excessive recursion. While it is not in general possible to
guarantee that we do not exceed stack limits (because the system can be
configured with an arbitrarily small stack), setting a reasonable recursion
limit will at least keep the fuzzer from continually finding more "bugs" like
this.

BUG=skia:5899
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2459573003

Committed:
https://skia.googlesource.com/skia/+/cad6416ccbf103648874b0f5fb615ec5ac798f14
==========

[commit-bot: I haz the power, 2016-10-27 17:54:05]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cad6416ccbf103648874b0f5fb615ec5ac798f14