Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2459573002: Disable Api call optimizations for runtime call stats (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable Api call optimizations for runtime call stats Otherwise, we don't account for callbacks from optimized code anymore. R=verwaest@chromium.org,cbruni@chromium.org BUG= Committed: https://crrev.com/e52020c7898f288557db993519c42ebcca603c2a Cr-Commit-Position: refs/heads/master@{#40645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jochen (gone - plz use gerrit)
4 years, 1 month ago (2016-10-27 13:33:26 UTC) #1
jochen (gone - plz use gerrit)
I tested this on the youtube-polymer-watch page, and while it didn't degrade performance, the call ...
4 years, 1 month ago (2016-10-27 13:47:32 UTC) #4
Camillo Bruni
LGTM nice catch!
4 years, 1 month ago (2016-10-27 14:17:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459573002/1
4 years, 1 month ago (2016-10-27 14:38:14 UTC) #9
Toon Verwaest
lgtm
4 years, 1 month ago (2016-10-28 12:40:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459573002/1
4 years, 1 month ago (2016-10-28 12:50:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 12:52:24 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e52020c7898f288557db993519c42ebcca603c2a
Cr-Commit-Position: refs/heads/master@{#40645}

Powered by Google App Engine
This is Rietveld 408576698