Test font created from paint

Test font created from paint

This is meant to allow clients to migrate over to a SkFont api on canvas (e.g. drawText(text, font, paint)) while still permitting the current setters in paint (e.g. setTextSize, setFlags).

Committed: http://code.google.com/p/skia/source/detail?r=14997

[bungeman-skia, 2014-05-30 14:33:51]

https://codereview.chromium.org/245953003/diff/70001/tests/FontObjTest.cpp
File tests/FontObjTest.cpp (right):

https://codereview.chromium.org/245953003/diff/70001/tests/FontObjTest.cpp#ne...
tests/FontObjTest.cpp:13: static bool use_nonlinear_metrics(const SkPaint&
paint) {
These sound imperative instead of interrogative.

[reed1, 2014-05-30 14:38:58]

ptal

https://codereview.chromium.org/245953003/diff/70001/tests/FontObjTest.cpp
File tests/FontObjTest.cpp (right):

https://codereview.chromium.org/245953003/diff/70001/tests/FontObjTest.cpp#ne...
tests/FontObjTest.cpp:13: static bool use_nonlinear_metrics(const SkPaint&
paint) {
On 2014/05/30 14:33:51, bungeman1 wrote:
> These sound imperative instead of interrogative.

Done.

[f(malita), 2014-05-30 15:02:43]

https://codereview.chromium.org/245953003/diff/70001/include/core/SkFont.h
File include/core/SkFont.h (right):

https://codereview.chromium.org/245953003/diff/70001/include/core/SkFont.h#ne...
include/core/SkFont.h:9: #include "SkScalar.h"
Should these be inside the include guard?

[reed1, 2014-05-30 15:07:14]

https://codereview.chromium.org/245953003/diff/70001/include/core/SkFont.h
File include/core/SkFont.h (right):

https://codereview.chromium.org/245953003/diff/70001/include/core/SkFont.h#ne...
include/core/SkFont.h:9: #include "SkScalar.h"
On 2014/05/30 15:02:44, Florin Malita wrote:
> Should these be inside the include guard?

Done.

[reed1, 2014-05-30 15:09:35]

ptal

[bungeman-skia, 2014-05-30 15:18:27]

lgtm at PS7

[f(malita), 2014-05-30 15:25:05]

lgtm

[eae, 2014-05-30 15:27:58]

LGTM

[reed1, 2014-05-30 16:18:15]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-30 16:18:57]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/245953003/110001

[commit-bot: I haz the power, 2014-05-30 16:28:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[commit-bot: I haz the power, 2014-05-30 16:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 16:33:25]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)

[reed1, 2014-05-30 16:39:16]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-30 16:39:59]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/245953003/130001

[commit-bot: I haz the power, 2014-05-30 16:46:15]

Change committed as 14997