third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html - Issue 2459523002: bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html

Issue 2459523002: bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any… (Closed)

Patch Set: s/foo/TestName/ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bluetooth/web_bluetooth_service_impl.cc ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-no-permission-for-any-service.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service.html b/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html

similarity index 54%

copy from third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service.html

copy to third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html

index 193943cb0a509fe137d8adbe10de20e8c3185ed1..8698fdeca5b7cde6f0c34f6023fc57938ba2ddb2 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html

@@ -1,3 +1,4 @@

+

<!DOCTYPE html>

@@ -10,7 +11,13 @@ promise_test(() => {

filters: [{name: 'Heart Rate Device'}]}))

.then(device => device.gatt.connect())

.then(gattServer => assert_promise_rejects_with_message(

- gattServer.getPrimaryServices(),

- new DOMException('No Services found in device.', 'NotFoundError')));

-}, 'Delayed service discovery, request for present service without permission. Reject with NotFoundError.');

+ gattServer.getPrimaryService('heart_rate'),

+ new DOMException('Origin is not allowed to access any service. Tip: ' +

+ 'Add the service UUID to \'optionalServices\' in ' +

+ 'requestDevice() options. https://goo.gl/HxfxSQ',

+ 'SecurityError')));

+}, 'Delayed service discovery, request for present service without ' +

+ 'permission to access any service. Reject with SecurityError.');

+</script>

</script>