third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission.html - Issue 2459523002: bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any…

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission.html

Issue 2459523002: bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any… (Closed)

Patch Set: Address Gio's feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission-present-service.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{name: 'Heart Rate Device'}]}))	10 filters: [{name: 'Heart Rate Device'}]}))

11 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

12 .then(gattServer => assert_promise_rejects_with_message(	12 .then(gattServer => assert_promise_rejects_with_message(

13 gattServer.getPrimaryServices(),	13 gattServer.getPrimaryServices(),

14 new DOMException('No Services found in device.', 'NotFoundError')));	14 new DOMException('Origin is not allowed to access any service. Tip: ' +
	ortuno 2016/11/03 05:30:26 Could you use the new script-tests pattern? You w Could you use the new script-tests pattern? You will need to create two new files service-no-permission-for-any-service.js and service-delayed-discovery-no-permission-for-any-service.js in bluetooth/scrip-tests/ and instead of gattServer.getPrimaryServices() you would have: gattServer.CALLS([ getPrimaryService('heart_rate')\| getPrimaryServices()\| getPrimaryServices('heart_rate')]), Then running third_party/WebKit/LayoutTests/bluetooth/generate.py should generate six new tests. François Beaufort 2016/11/03 13:00:01 I had to use [UUID] to generate 6 tests (not 4). Show quoted text On 2016/11/03 05:30:26, ortuno wrote: > Could you use the new script-tests pattern? > > You will need to create two new files service-no-permission-for-any-service.js > and service-delayed-discovery-no-permission-for-any-service.js in > bluetooth/scrip-tests/ > > and instead of gattServer.getPrimaryServices() you would have: > > gattServer.CALLS([ > getPrimaryService('heart_rate')\| > getPrimaryServices()\| > getPrimaryServices('heart_rate')]), > > Then running third_party/WebKit/LayoutTests/bluetooth/generate.py should > generate six new tests. I had to use [UUID] to generate 6 tests (not 4). Done.
15 }, 'Request for present service without permission. Reject with NotFoundError.') ;	15 'Add the service UUID to \'optionalServices\' in ' +

	16 'requestDevice() options. https://goo.gl/HxfxSQ',

	17 'SecurityError')));

	18 }, 'Request for present service without permission. Reject with SecurityError.') ;
	ortuno 2016/11/03 05:30:26 Please make the description more specific so that Please make the description more specific so that it's easier to understand how this is different from the other test. François Beaufort 2016/11/03 13:00:02 Done. Show quoted text On 2016/11/03 05:30:26, ortuno wrote: > Please make the description more specific so that it's easier to understand how > this is different from the other test. Done.
16 </script>	19 </script>

OLD	NEW