Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2459503002: Revert of Roll OpenH264 from v1.4.1 to v1.6.0 (Closed)

Created:
4 years, 1 month ago by sprang_chromium
Modified:
4 years, 1 month ago
Reviewers:
mcasas, hbos_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll OpenH264 from v1.4.1 to v1.6.0 (patchset #5 id:80001 of https://codereview.chromium.org/2440143002/ ) Reason for revert: Causing perf regression in webrtc. Original issue's description: > Roll OpenH264 from v1.4.1 to v1.6.0 > > BUG=chromium:614970 > > Committed: https://crrev.com/ae101afbcb955c6efbbf27bebf81334b95659c11 > Cr-Commit-Position: refs/heads/master@{#427688} TBR=mcasas@chromium.org,hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:614970 Committed: https://crrev.com/81bedff4d32896e3aa6b18f187d75ac16f19bc00 Cr-Commit-Position: refs/heads/master@{#428669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_recorder.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/openh264/BUILD.gn View 6 chunks +2 lines, -18 lines 0 comments Download
M third_party/openh264/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sprang_chromium
Created Revert of Roll OpenH264 from v1.4.1 to v1.6.0
4 years, 1 month ago (2016-10-27 10:39:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459503002/1
4 years, 1 month ago (2016-10-27 10:40:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-27 10:40:02 UTC) #5
hbos_chromium
lgtm
4 years, 1 month ago (2016-10-28 08:49:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459503002/1
4 years, 1 month ago (2016-10-31 09:02:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 09:03:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 09:10:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81bedff4d32896e3aa6b18f187d75ac16f19bc00
Cr-Commit-Position: refs/heads/master@{#428669}

Powered by Google App Engine
This is Rietveld 408576698