Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2459463003: Remove DCHECK since error is properly handled. (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years, 1 month ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK since error is properly handled. Prevents fuzzer test from completing and is frowned upon by the Chromium style guide. BUG=659184 TEST=none Committed: https://crrev.com/fc85f147a3fd757dd8caac1e59114122a529cc8a Cr-Commit-Position: refs/heads/master@{#428139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M media/formats/mp4/box_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
DaleCurtis
4 years, 1 month ago (2016-10-27 18:46:08 UTC) #2
wolenetz
That DCHECK's ugly, indeed. It's been there since the beginning of MSE mp4 parsing, too. ...
4 years, 1 month ago (2016-10-27 19:47:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459463003/1
4 years, 1 month ago (2016-10-27 21:12:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 21:21:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:23:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc85f147a3fd757dd8caac1e59114122a529cc8a
Cr-Commit-Position: refs/heads/master@{#428139}

Powered by Google App Engine
This is Rietveld 408576698