Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2459443004: Add tracing to custom elements operations (Closed)

Created:
4 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
4 years, 1 month ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tracing to custom elements operations This adds traces in the 'blink' category to: - customElements.define (which could take arbitrarily long given upgrades) - HTMLConstructor (which is unavoidable cost per-instance, so of interest) - reaction queue invoking (you could probably work this out from JS stacks, but it is an interesting landmark and its overhead may be of interest) BUG=659918 Committed: https://crrev.com/82e96780380b30193a27d412282cda8ca103c382 Cr-Commit-Position: refs/heads/master@{#428924}

Patch Set 1 #

Patch Set 2 : Add tracing to invokeReactions. #

Patch Set 3 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 1 month ago (2016-10-31 00:44:12 UTC) #9
haraken
LGTM. (Elliott is ooo.)
4 years, 1 month ago (2016-10-31 08:32:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459443004/40001
4 years, 1 month ago (2016-11-01 01:32:02 UTC) #14
dominicc (has gone to gerrit)
On 2016/10/31 at 08:32:01, haraken wrote: > LGTM. > > (Elliott is ooo.) Oh, thank ...
4 years, 1 month ago (2016-11-01 01:32:07 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 03:24:26 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 03:27:54 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/82e96780380b30193a27d412282cda8ca103c382
Cr-Commit-Position: refs/heads/master@{#428924}

Powered by Google App Engine
This is Rietveld 408576698