Turn on Analytic AA in Chrome (Attempt 2)

Revert of Turn on Analytic AA in Chrome

This reverts commit bfd9b173dcb1cf8e53af9599424b1f1c5240551c.

Reason for revert: debug builds are failing browser_tests on several
platforms.

Original issue's description:
> Turn on Analytic AA in Chrome
> (This is our second attempt 2, which has the same diff as our attemp 1 https://codereview.chromium.org/2458433002/)
>
> Update cc_unittests png files to reflect our changes.
>
> We also downgraded some ref tests to pixel tests because
> there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
> circle boundaries. This seems to be reasonable as the test html usually
> has more layers than the ref html. In the future, we may set a
> configurable threshold for ref tests so we don't have to downgrade ref
> tests for this reason.
>
> This is the clean version of the closed issue
> https://codereview.chromium.org/2407393003/ (That issue has too many pngs
> (7000+) that cause some troubles with the rietveld.)

> We will review this CL, then manually patch all the remaining 7000+ pixel tests
> locally, and land it manually.

TBR=liyuqian@google.com

Committed: https://crrev.com/4f9e453e2e4c51353ebe31c4c76b74345e49551b
Cr-Commit-Position: refs/heads/master@{#428616}

[liyuqian, 2016-10-27 18:16:49]

Description was changed from

==========
Turn on Analytic AA in Chrome (Attempt 2)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
==========

to

==========
Turn on Analytic AA in Chrome (Attempt 2)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[liyuqian, 2016-10-27 18:18:29]

Description was changed from

==========
Turn on Analytic AA in Chrome (Attempt 2)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[liyuqian, 2016-10-27 18:18:30]

liyuqian@google.com changed reviewers:
+ ajuma@chromium.org, fmalita@chromium.org

[liyuqian, 2016-10-27 19:58:12]

Please take a look at this CL which is almost identical with our first attempt.
I changed one more ref test to adapt to our recent SkAAClip change 2452393002

I created this test mainly to rerun all the try bots to prepare for the manual
landing on Saturday.

[ajuma, 2016-10-27 21:19:35]

cc/ lgtm

[f(malita), 2016-10-29 15:09:20]

LGTM.

I'm running the rebasline bots and will try to land manually when complete.

[f(malita), 2016-10-29 18:48:46]

Description was changed from

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/bfd9b173dcb1cf8e53af9599424b...
==========

[f(malita), 2016-10-29 18:48:48]

Committed patchset #3 (id:40001) manually as
bfd9b173dcb1cf8e53af9599424b1f1c5240551c (presubmit successful).

[f(malita), 2016-10-29 18:50:16]

Landed the rebasline manually:
https://chromium.googlesource.com/chromium/src/+/bfd9b173dcb1cf8e53af9599424b...

 6334 files changed, 265 insertions(+), 237 deletions(-)

Note to sheriffs: given the size of this rebaseline, some fallout is to be
expected.  I'll check the tree later and try to clean up any layout test
failures.  If you notice trivial anti-aliasing layout test diffs, please
suppress and assign to myself or Yuquian, or feel free to re-rebaseline.

[commit-bot: I haz the power, 2016-10-29 19:03:35]

Description was changed from

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/bfd9b173dcb1cf8e53af9599424b...
==========

to

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org

Committed: https://crrev.com/bfd9b173dcb1cf8e53af9599424b1f1c5240551c
Patch from Yuqian Li <liyuqian@google.com>.

Cr-Commit-Position: refs/heads/master@{#428614}
==========

[commit-bot: I haz the power, 2016-10-29 23:04:46]

Description was changed from

==========
Turn on Analytic AA in Chrome
(This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org

Committed: https://crrev.com/bfd9b173dcb1cf8e53af9599424b1f1c5240551c
Patch from Yuqian Li <liyuqian@google.com>.

Cr-Commit-Position: refs/heads/master@{#428614}
==========

to

==========
Revert of Turn on Analytic AA in Chrome

This reverts commit bfd9b173dcb1cf8e53af9599424b1f1c5240551c.

Reason for revert: debug builds are failing browser_tests on several
platforms.

Original issue's description:
> Turn on Analytic AA in Chrome
> (This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)
>
> Update cc_unittests png files to reflect our changes.
>
> We also downgraded some ref tests to pixel tests because
> there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
> circle boundaries. This seems to be reasonable as the test html usually
> has more layers than the ref html. In the future, we may set a
> configurable threshold for ref tests so we don't have to downgrade ref
> tests for this reason.
>
> This is the clean version of the closed issue
> https://codereview.chromium.org/2407393003/ (That issue has too many pngs
> (7000+) that cause some troubles with the rietveld.)

> We will review this CL, then manually patch all the remaining 7000+ pixel
tests
> locally, and land it manually.

TBR=liyuqian@google.com

Committed: https://crrev.com/4f9e453e2e4c51353ebe31c4c76b74345e49551b
Cr-Commit-Position: refs/heads/master@{#428616}
==========

[commit-bot: I haz the power, 2016-10-29 23:04:47]

Patchset 3 (id:??) landed as
https://crrev.com/4f9e453e2e4c51353ebe31c4c76b74345e49551b
Cr-Commit-Position: refs/heads/master@{#428616}

[fmalita_google_do_not_use, 2016-10-29 23:12:27]

fmalita@google.com changed reviewers:
+ fmalita@google.com

[fmalita_google_do_not_use, 2016-10-29 23:12:28]

Reverted in 

https://chromium.googlesource.com/chromium/src/+/4f9e453e2e4c51353ebe31c4c76b...

due to debug browser_test failures:

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ASan%...

Not sure what's going on, the logs are truncated due to verbose SkScan_AAAPath
logging.  We should take out those debugfs.

[chromium-reviews, 2016-10-30 01:13:12]

Thank you Florin! I'll see how to fix it on Monday.

On Oct 29, 2016 7:12 PM, <fmalita@google.com> wrote:

> Reverted in
>
> https://chromium.googlesource.com/chromium/src/+/
> 4f9e453e2e4c51353ebe31c4c76b74345e49551b
>
> due to debug browser_test failures:
>
> https://uberchromegw.corp.google.com/i/chromium.linux/
> builders/Linux%20Tests%20%28dbg%29%281%29/builds/58416
>
> https://uberchromegw.corp.google.com/i/chromium.memory/
> builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/30955
>
> Not sure what's going on, the logs are truncated due to verbose
> SkScan_AAAPath
> logging. We should take out those debugfs.
>
> https://codereview.chromium.org/2459433003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-10-30 01:13:12]

Thank you Florin! I'll see how to fix it on Monday.

On Oct 29, 2016 7:12 PM, <fmalita@google.com> wrote:

> Reverted in
>
> https://chromium.googlesource.com/chromium/src/+/
> 4f9e453e2e4c51353ebe31c4c76b74345e49551b
>
> due to debug browser_test failures:
>
> https://uberchromegw.corp.google.com/i/chromium.linux/
> builders/Linux%20Tests%20%28dbg%29%281%29/builds/58416
>
> https://uberchromegw.corp.google.com/i/chromium.memory/
> builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/30955
>
> Not sure what's going on, the logs are truncated due to verbose
> SkScan_AAAPath
> logging. We should take out those debugfs.
>
> https://codereview.chromium.org/2459433003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[f(malita), 2016-10-31 19:27:18]

Description was changed from

==========
Revert of Turn on Analytic AA in Chrome

This reverts commit bfd9b173dcb1cf8e53af9599424b1f1c5240551c.

Reason for revert: debug builds are failing browser_tests on several
platforms.

Original issue's description:
> Turn on Analytic AA in Chrome
> (This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)
>
> Update cc_unittests png files to reflect our changes.
>
> We also downgraded some ref tests to pixel tests because
> there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
> circle boundaries. This seems to be reasonable as the test html usually
> has more layers than the ref html. In the future, we may set a
> configurable threshold for ref tests so we don't have to downgrade ref
> tests for this reason.
>
> This is the clean version of the closed issue
> https://codereview.chromium.org/2407393003/ (That issue has too many pngs
> (7000+) that cause some troubles with the rietveld.)

> We will review this CL, then manually patch all the remaining 7000+ pixel
tests
> locally, and land it manually.

TBR=liyuqian@google.com

Committed: https://crrev.com/4f9e453e2e4c51353ebe31c4c76b74345e49551b
Cr-Commit-Position: refs/heads/master@{#428616}
==========

to

==========
Revert of Turn on Analytic AA in Chrome

This reverts commit bfd9b173dcb1cf8e53af9599424b1f1c5240551c.

Reason for revert: debug builds are failing browser_tests on several
platforms.

Original issue's description:
> Turn on Analytic AA in Chrome
> (This is our second attempt 2, which has the same diff as our attemp 1
https://codereview.chromium.org/2458433002/)
>
> Update cc_unittests png files to reflect our changes.
>
> We also downgraded some ref tests to pixel tests because
> there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
> circle boundaries. This seems to be reasonable as the test html usually
> has more layers than the ref html. In the future, we may set a
> configurable threshold for ref tests so we don't have to downgrade ref
> tests for this reason.
>
> This is the clean version of the closed issue
> https://codereview.chromium.org/2407393003/ (That issue has too many pngs
> (7000+) that cause some troubles with the rietveld.)

> We will review this CL, then manually patch all the remaining 7000+ pixel
tests
> locally, and land it manually.

TBR=liyuqian@google.com

Committed: https://crrev.com/4f9e453e2e4c51353ebe31c4c76b74345e49551b
Cr-Commit-Position: refs/heads/master@{#428616}
==========