Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2459413002: Fixes possible crash in content shell shutdown (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes possible crash in content shell shutdown Destruction of WMState needs to be after ShellPlatformDataAura. BUG=660548 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/8634758638eb923138722ccfc16e2c5a2d965a2f Cr-Commit-Position: refs/heads/master@{#428767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/shell/browser/shell_views.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 1 month ago (2016-10-31 15:49:50 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-10-31 19:01:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459413002/1
4 years, 1 month ago (2016-10-31 19:16:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 19:28:14 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 19:49:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8634758638eb923138722ccfc16e2c5a2d965a2f
Cr-Commit-Position: refs/heads/master@{#428767}

Powered by Google App Engine
This is Rietveld 408576698