Removing self.Fails of browser pixel tests from pixel_expectations.py.

Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5
Cr-Commit-Position: refs/heads/master@{#429065}

[zakerinasab, 2016-10-31 13:26:31]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[zakerinasab, 2016-10-31 13:27:30]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[zakerinasab, 2016-10-31 13:27:30]

zakerinasab@chromium.org changed reviewers:
+ kbr@chromium.org

[zakerinasab, 2016-10-31 13:28:52]

On 2016/10/31 13:27:30, zakerinasab wrote:
> mailto:zakerinasab@chromium.org changed reviewers:
> + mailto:kbr@chromium.org

TBR kbr@chromium.org

[zakerinasab, 2016-10-31 13:28:57]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 13:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:29:17]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ken Russell (switch to Gerrit), 2016-11-01 00:58:02]

LGTM assuming you've verified the reference images.

[Ken Russell (switch to Gerrit), 2016-11-01 00:58:05]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:37:22]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Russell (switch to Gerrit), 2016-11-01 02:43:32]

On 2016/11/01 01:37:22, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Definitely unrelated; I recommend you file a bug abou the flake, but re-cq'ing.

[Ken Russell (switch to Gerrit), 2016-11-01 02:43:36]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-01 02:43:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 04:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 04:43:16]

Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Ken Russell (switch to Gerrit), 2016-11-01 18:54:25]

On 2016/11/01 04:43:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_optional_gpu_tests_rel on master.tryserver.chromium.android
> (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

This may be the same issue as http://crbug.com/661233 . Bypassing the CQ.

[Ken Russell (switch to Gerrit), 2016-11-01 18:54:39]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-01 18:54:53]

On 2016/11/01 18:54:25, Ken Russell wrote:
> On 2016/11/01 04:43:16, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_optional_gpu_tests_rel on master.tryserver.chromium.android
> > (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
> 
> This may be the same issue as http://crbug.com/661233 . Bypassing the CQ.

Instead, removing android_optional_gpu_tests_rel from the optional tryservers.

[Ken Russell (switch to Gerrit), 2016-11-01 18:54:57]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:55:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 19:00:19]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-01 19:00:21]

Committed patchset #1 (id:1)

[zakerinasab, 2016-11-01 19:15:15]

On 2016/11/01 19:00:21, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

@Ken Thanks for addressing the android fail issue.

[commit-bot: I haz the power, 2016-11-01 19:29:06]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5
Cr-Commit-Position: refs/heads/master@{#429065}
==========

[commit-bot: I haz the power, 2016-11-01 19:29:07]

Patchset 1 (id:??) landed as
https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5
Cr-Commit-Position: refs/heads/master@{#429065}

[zakerinasab, 2016-11-24 19:35:28]

Description was changed from

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5
Cr-Commit-Position: refs/heads/master@{#429065}
==========

to

==========
Removing self.Fails of browser pixel tests from pixel_expectations.py.

As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.

BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5
Cr-Commit-Position: refs/heads/master@{#429065}
==========

[zakerinasab, 2016-11-24 19:36:52]

We need to land this patch again as we returned the self.Fails later. Now they
can be removed safely.

[zakerinasab, 2016-11-24 20:06:39]

On 2016/11/24 19:36:52, zakerinasab wrote:
> We need to land this patch again as we returned the self.Fails later. Now they
> can be removed safely.

Ah, I think it's better to create a new CL