Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2459363002: [GeometryInterface] parameter of scale3d*() was changed. (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] parameter of scale3d*() was changed. first parameter should be default parameter. if it is missing, that value should be one. spec list: - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale3d - https://drafts.fxtf.org/geometry/#dom-dommatrix-scale3dself BUG=388780, 660825 Committed: https://crrev.com/adf24dc879fc8963d3da560828187e23ef611437 Cr-Commit-Position: refs/heads/master@{#430566}

Patch Set 1 #

Patch Set 2 : add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Hwanseung Lee
@dominicc, @zino PTAL, thank you.
4 years, 1 month ago (2016-10-31 13:55:11 UTC) #5
Hwanseung Lee
@diminicc PTAL, thank you.
4 years, 1 month ago (2016-11-08 08:43:36 UTC) #8
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-08 08:49:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459363002/20001
4 years, 1 month ago (2016-11-08 08:49:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 10:27:14 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 10:30:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/adf24dc879fc8963d3da560828187e23ef611437
Cr-Commit-Position: refs/heads/master@{#430566}

Powered by Google App Engine
This is Rietveld 408576698