Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2459353002: Revert of Fix memory leak in NetworkThrottlingObserverTest (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix memory leak in NetworkThrottlingObserverTest (patchset #2 id:20001 of https://codereview.chromium.org/2465743003/ ) Reason for revert: Fix doesn't appear help. Reverting to be able to revert base CL. BUG=660769 Original issue's description: > Fix memory leak in NetworkThrottlingObserverTest > > DBusThreadManager is initialized but not shut down in > NetworkThrottlingObserverTest. This causes one of the trybots > to fail. > While there, fix a couple of style issues. > > BUG=chromium:634529, chromium:642811 > > Committed: https://crrev.com/441d475906634f882776abee5847f04162226a73 > Cr-Commit-Position: refs/heads/master@{#428675} TBR=thestig@chromium.org,stevenjb@chromium.org,kirtika@google.com,satorux@chromium.org,kirtika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:634529, chromium:642811 Committed: https://crrev.com/c90183bb2178b4778b80d4705361b838577dc300 Cr-Commit-Position: refs/heads/master@{#428692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/chromeos/net/network_throttling_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_throttling_observer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
phoglund_chromium
Created Revert of Fix memory leak in NetworkThrottlingObserverTest
4 years, 1 month ago (2016-10-31 12:42:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459353002/1
4 years, 1 month ago (2016-10-31 12:42:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 12:43:40 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 12:45:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c90183bb2178b4778b80d4705361b838577dc300
Cr-Commit-Position: refs/heads/master@{#428692}

Powered by Google App Engine
This is Rietveld 408576698