Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc

Issue 2459343002: Disabling flaky LocalDiscoveryUITest.RegisterTest (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("checkOneDevice")); 508 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("checkOneDevice"));
509 509
510 test_service_discovery_client()->SimulateReceive( 510 test_service_discovery_client()->SimulateReceive(
511 kGoodbyePacket, sizeof(kGoodbyePacket)); 511 kGoodbyePacket, sizeof(kGoodbyePacket));
512 512
513 RunFor(base::TimeDelta::FromMilliseconds(1100)); 513 RunFor(base::TimeDelta::FromMilliseconds(1100));
514 514
515 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("checkNoDevices")); 515 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("checkNoDevices"));
516 } 516 }
517 517
518 518 // Flaky: http://crbug.com/660669.
519 IN_PROC_BROWSER_TEST_F(LocalDiscoveryUITest, RegisterTest) { 519 IN_PROC_BROWSER_TEST_F(LocalDiscoveryUITest, DISABLED_RegisterTest) {
520 TestMessageLoopCondition condition_token_claimed; 520 TestMessageLoopCondition condition_token_claimed;
521 521
522 ui_test_utils::NavigateToURL(browser(), GURL( 522 ui_test_utils::NavigateToURL(browser(), GURL(
523 chrome::kChromeUIDevicesURL)); 523 chrome::kChromeUIDevicesURL));
524 condition_devices_listed().Wait(); 524 condition_devices_listed().Wait();
525 525
526 test_service_discovery_client()->SimulateReceive( 526 test_service_discovery_client()->SimulateReceive(
527 kAnnouncePacket, sizeof(kAnnouncePacket)); 527 kAnnouncePacket, sizeof(kAnnouncePacket));
528 528
529 base::RunLoop().RunUntilIdle(); 529 base::RunLoop().RunUntilIdle();
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 kAnnouncePacketRegistered, sizeof(kAnnouncePacketRegistered)); 580 kAnnouncePacketRegistered, sizeof(kAnnouncePacketRegistered));
581 581
582 base::RunLoop().RunUntilIdle(); 582 base::RunLoop().RunUntilIdle();
583 583
584 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("expectRegisterDone")); 584 EXPECT_TRUE(WebUIBrowserTest::RunJavascriptTest("expectRegisterDone"));
585 } 585 }
586 586
587 } // namespace 587 } // namespace
588 588
589 } // namespace local_discovery 589 } // namespace local_discovery
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698