Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2459333003: [ic] Detailize some IC-specific runtime call stats counters. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Detailize some IC-specific runtime call stats counters. This CL adds Load/StoreIC_Premonomorphic and detailizes IC_HandlerCacheHit bucket. BUG=v8:5561 Committed: https://crrev.com/597315dc13b786f1798d47c2eccb200f1b3974f9 Cr-Commit-Position: refs/heads/master@{#40679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -4 lines) Patch
M src/counters.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +68 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-31 17:20:47 UTC) #8
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-31 17:24:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459333003/20001
4 years, 1 month ago (2016-10-31 17:33:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-31 17:47:59 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:28 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/597315dc13b786f1798d47c2eccb200f1b3974f9
Cr-Commit-Position: refs/heads/master@{#40679}

Powered by Google App Engine
This is Rietveld 408576698