Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/browser/extensions/api/browser/browser_api.cc

Issue 245933002: Initial implementation of chrome.browser.openTab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/extensions/api/browser/browser_api.h"
6
7 #include "chrome/browser/extensions/extension_tab_util.h"
8
9 namespace extensions {
10 namespace api {
11
12 BrowserOpenTabFunction::~BrowserOpenTabFunction() {
13 }
14
15 bool BrowserOpenTabFunction::RunSync() {
16 scoped_ptr<browser::OpenTab::Params> params(
17 browser::OpenTab::Params::Create(*args_));
18 EXTENSION_FUNCTION_VALIDATE(params.get());
19
20 ExtensionTabUtil::OpenTabParams options;
21 options.create_browser_if_needed = true;
22 options.url.reset(new std::string(params->options.url));
23
24 std::string error;
25 scoped_ptr<base::DictionaryValue> result(
26 ExtensionTabUtil::OpenTab(this, options, &error));
27 if (!result) {
28 SetError(error);
29 return false;
30 }
31
32 return true;
33 }
34
35 } // namespace api
36 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/browser/browser_api.h ('k') | chrome/browser/extensions/api/browser/browser_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698