Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2459273002: [turbofan] Properly deal with out-of-bounds fields in EscapeAnalysis. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly deal with out-of-bounds fields in EscapeAnalysis. Conflicting type feedback on Load/StoreICs can lead to out-of-bounds field access, which is essentially dead code, but EscapeAnalysis was confused about those. For now, mark the objects as escaping in these cases, middle-term we want to deal better with this kind of compile- time known dead code. BUG=chromium:658185, v8:4586 R=jarin@chromium.org Committed: https://crrev.com/7201bad99d16c0e4e9f33ebc14ddb80446b06a51 Cr-Commit-Position: refs/heads/master@{#40662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M src/compiler/escape-analysis.cc View 2 chunks +28 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-658185.js View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-31 04:55:25 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the quickfix for escape analysis that we agreed on last week. Please ...
4 years, 1 month ago (2016-10-31 04:58:46 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-10-31 06:39:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459273002/1
4 years, 1 month ago (2016-10-31 06:41:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 06:43:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7201bad99d16c0e4e9f33ebc14ddb80446b06a51
Cr-Commit-Position: refs/heads/master@{#40662}

Powered by Google App Engine
This is Rietveld 408576698