Chromium Code Reviews| Index: net/http/http_util.cc |
| diff --git a/net/http/http_util.cc b/net/http/http_util.cc |
| index aa2fdb6d66e9136695518474c52c53402774ffba..ff8e04cc616d28a0b2fa65b5f4d20f2687adb71b 100644 |
| --- a/net/http/http_util.cc |
| +++ b/net/http/http_util.cc |
| @@ -345,9 +345,11 @@ bool HttpUtil::IsSafeHeader(const std::string& name) { |
| if (base::StartsWith(lower_name, "proxy-", base::CompareCase::SENSITIVE) || |
| base::StartsWith(lower_name, "sec-", base::CompareCase::SENSITIVE)) |
| return false; |
| - for (size_t i = 0; i < arraysize(kForbiddenHeaderFields); ++i) { |
| - if (lower_name == kForbiddenHeaderFields[i]) |
| + |
| + for (const char* field : kForbiddenHeaderFields) { |
| + if (lower_name == field) { |
| return false; |
| + } |
|
mmenke
2016/10/31 14:49:30
nit: Don't use braces for ifs with a single line
|
| } |
| return true; |
| } |
| @@ -414,9 +416,10 @@ bool HttpUtil::IsNonCoalescingHeader(std::string::const_iterator name_begin, |
| // one. |
| "strict-transport-security" |
| }; |
| - for (size_t i = 0; i < arraysize(kNonCoalescingHeaders); ++i) { |
| + |
| + for (const char* header : kNonCoalescingHeaders) { |
| if (base::LowerCaseEqualsASCII(base::StringPiece(name_begin, name_end), |
| - kNonCoalescingHeaders[i])) |
| + header)) |
| return true; |
|
mmenke
2016/10/31 14:49:30
nit: Mind adding braces to this if, though, while
|
| } |
| return false; |