Replace for each loops

net/http/http_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The rules for parsing content-types were borrowed from Firefox:
 // http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsURLHelper.cpp#834
 
 #include "net/http/http_util.h"
 
 #include <algorithm>
@@ skipping 327 matching lines @@
   "via",
 };
 }  // anonymous namespace
 
 // static
 bool HttpUtil::IsSafeHeader(const std::string& name) {
   std::string lower_name(base::ToLowerASCII(name));
   if (base::StartsWith(lower_name, "proxy-", base::CompareCase::SENSITIVE) ||
       base::StartsWith(lower_name, "sec-", base::CompareCase::SENSITIVE))
     return false;
-  for (size_t i = 0; i < arraysize(kForbiddenHeaderFields); ++i) {
-    if (lower_name == kForbiddenHeaderFields[i])
+
+  for (const char* field : kForbiddenHeaderFields) {
+    if (lower_name == field) {
       return false;
+    }

[mmenke, 2016/10/31 14:49:30]

nit:  Don't use braces for ifs with a single line conditional and single line
body.

   }
   return true;
 }
 
 // static
 bool HttpUtil::IsValidHeaderName(const base::StringPiece& name) {
   // Check whether the header name is RFC 2616-compliant.
   return HttpUtil::IsToken(name);
 }
 
@@ skipping 46 matching lines @@
     "retry-after",
     "set-cookie",
     // The format of auth-challenges mixes both space separated tokens and
     // comma separated properties, so coalescing on comma won't work.
     "www-authenticate",
     "proxy-authenticate",
     // STS specifies that UAs must not process any STS headers after the first
     // one.
     "strict-transport-security"
   };
-  for (size_t i = 0; i < arraysize(kNonCoalescingHeaders); ++i) {
+
+  for (const char* header : kNonCoalescingHeaders) {
     if (base::LowerCaseEqualsASCII(base::StringPiece(name_begin, name_end),
-                                   kNonCoalescingHeaders[i]))
+                                   header))
       return true;

[mmenke, 2016/10/31 14:49:30]

nit:  Mind adding braces to this if, though, while you're here, since the
condition takes up two lines?

   }
   return false;
 }
 
 bool HttpUtil::IsLWS(char c) {
   return strchr(HTTP_LWS, c) != NULL;
 }
 
 // static
 void HttpUtil::TrimLWS(std::string::const_iterator* begin,
@@ skipping 639 matching lines @@
   return true;
 }
 
 bool HttpUtil::NameValuePairsIterator::IsQuote(char c) const {
   if (strict_quotes_)
     return c == '"';
   return HttpUtil::IsQuote(c);
 }
 
 }  // namespace net