Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2459243002: Replace for each loops (Closed)

Created:
4 years, 1 month ago by Yoonjae
Modified:
4 years, 1 month ago
Reviewers:
mmenke, Yoonjae
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace for each loops BUG=655950 Committed: https://crrev.com/9bd6ef5d4c1f52c0cbc5da2075f19c10577e337b Cr-Commit-Position: refs/heads/master@{#429052}

Patch Set 1 #

Patch Set 2 : Replace for each loop #

Total comments: 2

Patch Set 3 : Replace for each loops with format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_util.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Yoonjae
@mmenke PTAL.
4 years, 1 month ago (2016-10-31 03:21:19 UTC) #3
mmenke
Looks good, just a pair of very minor comments. And for the record, I've verified ...
4 years, 1 month ago (2016-10-31 14:49:30 UTC) #4
Yoonjae
On 2016/10/31 14:49:30, mmenke (Busy Nov 2-3) wrote: > Looks good, just a pair of ...
4 years, 1 month ago (2016-11-01 09:10:35 UTC) #5
mmenke
LGTM, thanks for the cleanup!
4 years, 1 month ago (2016-11-01 13:53:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459243002/40001
4 years, 1 month ago (2016-11-01 14:55:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/308771)
4 years, 1 month ago (2016-11-01 16:56:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459243002/40001
4 years, 1 month ago (2016-11-01 17:21:17 UTC) #12
mmenke
On 2016/11/01 16:56:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-01 17:21:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 18:11:34 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:24:58 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9bd6ef5d4c1f52c0cbc5da2075f19c10577e337b
Cr-Commit-Position: refs/heads/master@{#429052}

Powered by Google App Engine
This is Rietveld 408576698