Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 245923005: libeven message-pump: Fix a particular case of nested message-loop runs. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

libevent message-pump: Fix a particular case of nested message-loop runs. If Quit() is called on the message-pump to terminate a nested loop, followed by a call to Run() again to start another nested loop, in the same iteration of the loop, then make sure it all works correctly. We have this scenario with nested menus, modal dialogs, drag-drop etc. in the browser UI. So this is a prerequisite fix to be able to use the libevent based message-pump on Chrome OS (and get rid of glib dep). BUG=240715 R=sky@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266628

Patch Set 1 #

Patch Set 2 : change-string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M base/message_loop/message_pump_libevent.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 1 3 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
6 years, 8 months ago (2014-04-22 20:59:27 UTC) #1
sadrul
+sky@ to load-balance review burden
6 years, 8 months ago (2014-04-24 23:16:01 UTC) #2
sky
LGTM
6 years, 8 months ago (2014-04-25 14:31:38 UTC) #3
sadrul
[ TBR'ing to darin@ ]
6 years, 7 months ago (2014-04-28 19:30:13 UTC) #4
sadrul
Committed patchset #2 manually as r266628 (presubmit successful).
6 years, 7 months ago (2014-04-28 19:30:43 UTC) #5
darin (slow to review)
6 years, 7 months ago (2014-04-28 19:32:13 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698