Open ChromeOS clock settings on the UI thread instead of File.

chrome/browser/interstitials/chrome_controller_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/interstitials/chrome_controller_client.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/process/launch.h"
@@ skipping 24 matching lines @@
 #include "base/base_paths_win.h"
 #include "base/path_service.h"
 #include "base/strings/string16.h"
 #include "base/win/windows_version.h"
 #endif
 
 using content::Referrer;
 
 namespace {
 
-void LaunchDateAndTimeSettingsOnFile() {
+void LaunchDateAndTimeSettingsOnFileThread() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
 // The code for each OS is completely separate, in order to avoid bugs like
-// https://crbug.com/430877 .
+// https://crbug.com/430877 . ChromeOS is handled on the UI thread.
 #if defined(OS_ANDROID)
   chrome::android::OpenDateAndTimeSettings();

[estark, 2016/10/31 19:02:49]

I wonder if this should be on the UI thread as well. I can't figure out if
sending an intent is a blocking operation or not... do you know?

[meacer, 2016/10/31 21:38:22]

Yeah, I was wondering the same thing. 

I don't know about this specific intent, but there is another one in that file
called SendMail. SendMail is called from the UI thread:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/net_export_ui.cc...

I can't tell which one is the correct one. How about I land this and keep the
bug open to investigate?

 
-#elif defined(OS_CHROMEOS)
-  std::string sub_page =
-      std::string(chrome::kSearchSubPage) + "#" +
-      l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
-  chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(),
-                                        sub_page);
-
 #elif defined(OS_LINUX)
   struct ClockCommand {
-    const char* pathname;
-    const char* argument;
+    const char* const pathname;
+    const char* const argument;
   };
   static const ClockCommand kClockCommands[] = {
       // Unity
       {"/usr/bin/unity-control-center", "datetime"},
       // GNOME
       //
       // NOTE: On old Ubuntu, naming control panels doesn't work, so it
       // opens the overview. This will have to be good enough.
       {"/usr/bin/gnome-control-center", "datetime"},
       {"/usr/local/bin/gnome-control-center", "datetime"},
@@ skipping 70 matching lines @@
 bool ChromeControllerClient::CanLaunchDateAndTimeSettings() {
 #if defined(OS_ANDROID) || defined(OS_CHROMEOS) || defined(OS_LINUX) || \
     defined(OS_MACOSX) || defined(OS_WIN)
   return true;
 #else
   return false;
 #endif
 }
 
 void ChromeControllerClient::LaunchDateAndTimeSettings() {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+#if defined(OS_CHROMEOS)
+  const std::string sub_page =
+      std::string(chrome::kSearchSubPage) + "#" +
+      l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
+  chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(),
+                                        sub_page);
+#else
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
-      base::Bind(&LaunchDateAndTimeSettingsOnFile));
+      base::Bind(&LaunchDateAndTimeSettingsOnFileThread));
+#endif
 }
 
 void ChromeControllerClient::GoBack() {
   interstitial_page_->DontProceed();
 }
 
 void ChromeControllerClient::Proceed() {
   interstitial_page_->Proceed();
 }
 
@@ skipping 14 matching lines @@
 
 PrefService* ChromeControllerClient::GetPrefService() {
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   return profile->GetPrefs();
 }
 
 const std::string ChromeControllerClient::GetExtendedReportingPrefName() {
   return prefs::kSafeBrowsingExtendedReportingEnabled;
 }