extensions/shell/renderer/shell_content_renderer_client.cc - Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/renderer/shell_content_renderer_client.cc

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)

Patch Set: compile fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/renderer/shell_content_renderer_client.cc

diff --git a/extensions/shell/renderer/shell_content_renderer_client.cc b/extensions/shell/renderer/shell_content_renderer_client.cc

index 92b71496687c69f4ac141abd458315193aae82c2..dc70d11ffab6c49e9636efe46a3bed3213b9f624 100644

--- a/extensions/shell/renderer/shell_content_renderer_client.cc

+++ b/extensions/shell/renderer/shell_content_renderer_client.cc

@@ -97,8 +97,7 @@ blink::WebPlugin* ShellContentRendererClient::CreatePluginReplacement(

bool ShellContentRendererClient::WillSendRequest(

blink::WebFrame* frame,

ui::PageTransition transition_type,

- const GURL& url,

- const GURL& first_party_for_cookies,

+ const blink::WebURL& url,

GURL* new_url) {

// TODO(jamescook): Cause an error for bad extension scheme requests?

return false;