chrome/renderer/chrome_content_renderer_client.h - Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)

Patch Set: compile fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.h

diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h

index c32efe22fda3d6bb631690d5f3b8685aa3eace8b..3438d0fc58c033bc9b1880aa6be286439529e695 100644

--- a/chrome/renderer/chrome_content_renderer_client.h

+++ b/chrome/renderer/chrome_content_renderer_client.h

@@ -134,8 +134,7 @@ class ChromeContentRendererClient : public content::ContentRendererClient {

bool* send_referrer) override;

bool WillSendRequest(blink::WebFrame* frame,

ui::PageTransition transition_type,

- const GURL& url,

- const GURL& first_party_for_cookies,

+ const blink::WebURL& url,

GURL* new_url) override;

bool IsPrefetchOnly(content::RenderFrame* render_frame,

const blink::WebURLRequest& request) override;