Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)
Patch Set: s/host/host_piece Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/resource_request_policy.h" 5 #include "chrome/renderer/extensions/resource_request_policy.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "chrome/common/extensions/chrome_manifest_url_handlers.h" 9 #include "chrome/common/extensions/chrome_manifest_url_handlers.h"
10 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
11 #include "extensions/common/constants.h" 11 #include "extensions/common/constants.h"
12 #include "extensions/common/extension.h" 12 #include "extensions/common/extension.h"
13 #include "extensions/common/manifest_constants.h" 13 #include "extensions/common/manifest_constants.h"
14 #include "extensions/common/manifest_handlers/icons_handler.h" 14 #include "extensions/common/manifest_handlers/icons_handler.h"
15 #include "extensions/common/manifest_handlers/web_accessible_resources_info.h" 15 #include "extensions/common/manifest_handlers/web_accessible_resources_info.h"
16 #include "extensions/common/manifest_handlers/webview_info.h" 16 #include "extensions/common/manifest_handlers/webview_info.h"
17 #include "extensions/renderer/dispatcher.h" 17 #include "extensions/renderer/dispatcher.h"
18 #include "extensions/renderer/renderer_extension_registry.h" 18 #include "extensions/renderer/renderer_extension_registry.h"
19 #include "third_party/WebKit/public/platform/URLConversion.h" 19 #include "third_party/WebKit/public/platform/URLConversion.h"
20 #include "third_party/WebKit/public/platform/WebString.h" 20 #include "third_party/WebKit/public/platform/WebString.h"
21 #include "third_party/WebKit/public/platform/WebURL.h"
21 #include "third_party/WebKit/public/web/WebConsoleMessage.h" 22 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
22 #include "third_party/WebKit/public/web/WebDocument.h" 23 #include "third_party/WebKit/public/web/WebDocument.h"
23 #include "third_party/WebKit/public/web/WebFrame.h" 24 #include "third_party/WebKit/public/web/WebFrame.h"
24 #include "ui/base/page_transition_types.h" 25 #include "ui/base/page_transition_types.h"
25 #include "url/gurl.h" 26 #include "url/gurl.h"
26 #include "url/origin.h" 27 #include "url/origin.h"
27 28
28 namespace extensions { 29 namespace extensions {
29 30
30 ResourceRequestPolicy::ResourceRequestPolicy(Dispatcher* dispatcher) 31 ResourceRequestPolicy::ResourceRequestPolicy(Dispatcher* dispatcher)
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 blink::WebConsoleMessage(blink::WebConsoleMessage::LevelError, 108 blink::WebConsoleMessage(blink::WebConsoleMessage::LevelError,
108 blink::WebString::fromUTF8(message))); 109 blink::WebString::fromUTF8(message)));
109 return false; 110 return false;
110 } 111 }
111 } 112 }
112 113
113 return true; 114 return true;
114 } 115 }
115 116
116 bool ResourceRequestPolicy::CanRequestExtensionResourceScheme( 117 bool ResourceRequestPolicy::CanRequestExtensionResourceScheme(
117 const GURL& resource_url, 118 const blink::WebURL& resource_url,
118 blink::WebFrame* frame) { 119 blink::WebFrame* frame) {
119 CHECK(resource_url.SchemeIs(kExtensionResourceScheme)); 120 CHECK(resource_url.protocolIs(kExtensionResourceScheme));
120 121
121 GURL frame_url = frame->document().url(); 122 GURL frame_url = frame->document().url();
122 if (!frame_url.is_empty() && !frame_url.SchemeIs(kExtensionScheme)) { 123 if (!frame_url.is_empty() && !frame_url.SchemeIs(kExtensionScheme)) {
123 std::string message = base::StringPrintf( 124 std::string message = base::StringPrintf(
124 "Denying load of %s. chrome-extension-resources:// can only be " 125 "Denying load of %s. chrome-extension-resources:// can only be "
125 "loaded from extensions.", 126 "loaded from extensions.",
126 resource_url.spec().c_str()); 127 resource_url.string().utf8().c_str());
127 frame->addMessageToConsole( 128 frame->addMessageToConsole(
128 blink::WebConsoleMessage(blink::WebConsoleMessage::LevelError, 129 blink::WebConsoleMessage(blink::WebConsoleMessage::LevelError,
129 blink::WebString::fromUTF8(message))); 130 blink::WebString::fromUTF8(message)));
130 return false; 131 return false;
131 } 132 }
132 133
133 return true; 134 return true;
134 } 135 }
135 136
136 } // namespace extensions 137 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/resource_request_policy.h ('k') | content/public/renderer/content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698