Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/renderer/extensions/chrome_extensions_renderer_client.cc

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)
Patch Set: s/host/host_piece Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/chrome_extensions_renderer_client.h" 5 #include "chrome/renderer/extensions/chrome_extensions_renderer_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 return !current_context->web_frame()->parent(); 203 return !current_context->web_frame()->parent();
204 default: 204 default:
205 NOTREACHED(); 205 NOTREACHED();
206 return false; 206 return false;
207 } 207 }
208 } 208 }
209 209
210 bool ChromeExtensionsRendererClient::WillSendRequest( 210 bool ChromeExtensionsRendererClient::WillSendRequest(
211 blink::WebFrame* frame, 211 blink::WebFrame* frame,
212 ui::PageTransition transition_type, 212 ui::PageTransition transition_type,
213 const GURL& url, 213 const blink::WebURL& url,
214 GURL* new_url) { 214 GURL* new_url) {
215 if (url.SchemeIs(extensions::kExtensionScheme) && 215 if (url.protocolIs(extensions::kExtensionScheme) &&
216 !resource_request_policy_->CanRequestResource(url, frame, 216 !resource_request_policy_->CanRequestResource(GURL(url), frame,
217 transition_type)) { 217 transition_type)) {
218 *new_url = GURL(chrome::kExtensionInvalidRequestURL); 218 *new_url = GURL(chrome::kExtensionInvalidRequestURL);
219 return true; 219 return true;
220 } 220 }
221 221
222 if (url.SchemeIs(extensions::kExtensionResourceScheme) && 222 if (url.protocolIs(extensions::kExtensionResourceScheme) &&
223 !resource_request_policy_->CanRequestExtensionResourceScheme(url, 223 !resource_request_policy_->CanRequestExtensionResourceScheme(url,
224 frame)) { 224 frame)) {
225 *new_url = GURL(chrome::kExtensionResourceInvalidRequestURL); 225 *new_url = GURL(chrome::kExtensionResourceInvalidRequestURL);
226 return true; 226 return true;
227 } 227 }
228 228
229 return false; 229 return false;
230 } 230 }
231 231
232 void ChromeExtensionsRendererClient::SetExtensionDispatcherForTest( 232 void ChromeExtensionsRendererClient::SetExtensionDispatcherForTest(
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 308
309 void ChromeExtensionsRendererClient::RunScriptsAtDocumentStart( 309 void ChromeExtensionsRendererClient::RunScriptsAtDocumentStart(
310 content::RenderFrame* render_frame) { 310 content::RenderFrame* render_frame) {
311 extension_dispatcher_->RunScriptsAtDocumentStart(render_frame); 311 extension_dispatcher_->RunScriptsAtDocumentStart(render_frame);
312 } 312 }
313 313
314 void ChromeExtensionsRendererClient::RunScriptsAtDocumentEnd( 314 void ChromeExtensionsRendererClient::RunScriptsAtDocumentEnd(
315 content::RenderFrame* render_frame) { 315 content::RenderFrame* render_frame) {
316 extension_dispatcher_->RunScriptsAtDocumentEnd(render_frame); 316 extension_dispatcher_->RunScriptsAtDocumentEnd(render_frame);
317 } 317 }
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/chrome_extensions_renderer_client.h ('k') | chrome/renderer/extensions/resource_request_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698