Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2459123003: Unsplit the MUS demo. (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unsplit the MUS demo code back into just one service, as it turns out the Android MUS demo can connect to the service instead of calling the demo directly. BUG=660623 Committed: https://crrev.com/5b4fdf8aaf344ec97c6e9dc3fc9c78469d04f9c7 Cr-Commit-Position: refs/heads/master@{#428801}

Patch Set 1 #

Patch Set 2 : Unsplit the MUS demo. #

Patch Set 3 : Unsplit the MUS demo. #

Patch Set 4 : Fixed gn check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -95 lines) Patch
M services/ui/demo/BUILD.gn View 1 2 3 3 chunks +12 lines, -20 lines 0 comments Download
M services/ui/demo/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/demo/mus_demo.h View 1 chunk +10 lines, -6 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +8 lines, -3 lines 0 comments Download
D services/ui/demo/mus_demo_service.h View 1 chunk +0 lines, -36 lines 0 comments Download
D services/ui/demo/mus_demo_service.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
Jay Civelli
4 years, 1 month ago (2016-10-29 01:56:14 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-10-31 15:07:28 UTC) #5
rjkroege
lgtm
4 years, 1 month ago (2016-10-31 17:23:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459123003/60001
4 years, 1 month ago (2016-10-31 17:54:59 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/97588)
4 years, 1 month ago (2016-10-31 18:29:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459123003/60001
4 years, 1 month ago (2016-10-31 20:05:12 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-31 20:51:33 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:56:04 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5b4fdf8aaf344ec97c6e9dc3fc9c78469d04f9c7
Cr-Commit-Position: refs/heads/master@{#428801}

Powered by Google App Engine
This is Rietveld 408576698