Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp

Issue 2459113002: [IDBObservers] Moving options from constructor to .observe call. (Closed)
Patch Set: added more exceptions, fixed tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp
index 7f530d73bc2ea9a18158ea616db93b73fac2a7e6..29feac2dd6fc8ded5994bd9eb37598136277f1d6 100644
--- a/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp
@@ -10,12 +10,27 @@ namespace blink {
// static
std::unique_ptr<WebIDBObserverImpl> WebIDBObserverImpl::create(
- IDBObserver* observer) {
- return wrapUnique(new WebIDBObserverImpl(observer));
+ IDBObserver* observer,
+ bool transaction,
+ bool values,
+ bool noRecords,
+ std::bitset<WebIDBOperationTypeCount>& operationTypes) {
+ return wrapUnique(new WebIDBObserverImpl(observer, transaction, values,
+ noRecords, operationTypes));
}
-WebIDBObserverImpl::WebIDBObserverImpl(IDBObserver* observer)
- : m_id(kInvalidObserverId), m_observer(observer) {}
+WebIDBObserverImpl::WebIDBObserverImpl(
+ IDBObserver* observer,
+ bool transaction,
+ bool values,
+ bool noRecords,
+ std::bitset<WebIDBOperationTypeCount>& operationTypes)
+ : m_id(kInvalidObserverId),
+ m_transaction(transaction),
+ m_values(values),
+ m_noRecords(noRecords),
+ m_operationTypes(operationTypes),
+ m_observer(observer) {}
// Remove observe call id from IDBObserver.
WebIDBObserverImpl::~WebIDBObserverImpl() {

Powered by Google App Engine
This is Rietveld 408576698